----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12013/#review22184 -----------------------------------------------------------
framework/src/org/apache/cordova/api/PluginManager.java <https://reviews.apache.org/r/12013/#comment45589> I realize these logs are at a high verbosity level (DEBUG). Are they intended to be left in? framework/src/org/apache/cordova/api/PluginManager.java <https://reviews.apache.org/r/12013/#comment45590> Doesn't the second case need to return true? It seems synchronous to me. - Braden Shepherdson On June 20, 2013, 8:16 p.m., Jeffrey Willms wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12013/ > ----------------------------------------------------------- > > (Updated June 20, 2013, 8:16 p.m.) > > > Review request for cordova and Andrew Grieve. > > > Description > ------- > > Fixing exec bug. > > > This addresses bug CB-3927. > https://issues.apache.org/jira/browse/CB-3927 > > > Diffs > ----- > > framework/src/org/apache/cordova/api/PluginEntry.java > 9b9af6bc303965e7263bca75037256da81868fb2 > framework/src/org/apache/cordova/api/PluginManager.java > 71fc25817b5d58bb2fbf5a29158ef2c7d424d4ab > > Diff: https://reviews.apache.org/r/12013/diff/ > > > Testing > ------- > > > Thanks, > > Jeffrey Willms > >
