+1
On Fri, Jul 26, 2013 at 6:58 PM, Filip Maj <[email protected]> wrote: > What do people think of the bin/create script copying the bin/check_reqs > script into project/cordova/lib folder at create time? Then all > sub-scripts under project/cordova are able to call into the > project/cordova/lib/check_reqs script. A shell script refactor. > > If this sounds like a good idea, should extend the command line tooling > design [1] doc. Perhaps worth "formalizing" the ./bin/ scripts api > surfaces in general? > > [1] http://wiki.apache.org/cordova/CommandLineToolingDesign > > On 7/26/13 5:59 PM, "Shazron" <[email protected]> wrote: > > >Generally I would agree but this cordova folder exists in the project > >itself, with no access to the check_reqs script with the cordova-ios/bin > >folder. > > > > > >On Fri, Jul 26, 2013 at 5:25 PM, Filip Maj <[email protected]> wrote: > > > >> Hey Shaz shouldn't the min version stuff be put into the bin/check_reqs > >> script? I'd like those types of bits to be put into one scripts as > >>various > >> parts of our toolchain need to call into that (also saves you the hassle > >> of updating n scripts every time) > >> > >> On 7/26/13 12:24 PM, "[email protected]" <[email protected]> wrote: > >> > >> >Updated Branches: > >> > refs/heads/master 3ca4b7a37 -> 96557e3dc > >> > > >> > > >> >[CB-4405] Increase Xcode minimum version to 4.6 in cordova/* scripts > >> > > >> > > >> >Project: http://git-wip-us.apache.org/repos/asf/cordova-ios/repo > >> >Commit: > >> http://git-wip-us.apache.org/repos/asf/cordova-ios/commit/96557e3d > >> >Tree: http://git-wip-us.apache.org/repos/asf/cordova-ios/tree/96557e3d > >> >Diff: http://git-wip-us.apache.org/repos/asf/cordova-ios/diff/96557e3d > >> > > >> >Branch: refs/heads/master > >> >Commit: 96557e3dc203dd829004bc49bfd322b651bdfe75 > >> >Parents: 3ca4b7a > >> >Author: Shazron Abdullah <[email protected]> > >> >Authored: Fri Jul 26 12:24:36 2013 -0700 > >> >Committer: Shazron Abdullah <[email protected]> > >> >Committed: Fri Jul 26 12:24:36 2013 -0700 > >> > > >> >---------------------------------------------------------------------- > >> > bin/templates/project/cordova/build | 2 +- > >> > bin/templates/project/cordova/clean | 2 +- > >> > bin/templates/project/cordova/emulate | 2 +- > >> > bin/templates/project/cordova/lib/install-emulator | 2 +- > >> > bin/templates/project/cordova/run | 2 +- > >> > 5 files changed, 5 insertions(+), 5 deletions(-) > >> >---------------------------------------------------------------------- > >> > > >> > > >> > > >> > >> > http://git-wip-us.apache.org/repos/asf/cordova-ios/blob/96557e3d/bin/temp > >>l > >> >ates/project/cordova/build > >> >---------------------------------------------------------------------- > >> >diff --git a/bin/templates/project/cordova/build > >> >b/bin/templates/project/cordova/build > >> >index b34d576..29951d0 100755 > >> >--- a/bin/templates/project/cordova/build > >> >+++ b/bin/templates/project/cordova/build > >> >@@ -26,7 +26,7 @@ > >> > set -e > >> > > >> > XCODE_VER=$(xcodebuild -version | head -n 1 | sed -e 's/Xcode //') > >> >-XCODE_MIN_VERSION="4.5" > >> >+XCODE_MIN_VERSION="4.6" > >> > > >> > if [[ "$XCODE_VER" < "$XCODE_MIN_VERSION" ]]; then > >> > echo "Cordova can only run in Xcode version $XCODE_MIN_VERSION > >>or > >> >greater." > >> > > >> > > >> > >> > http://git-wip-us.apache.org/repos/asf/cordova-ios/blob/96557e3d/bin/temp > >>l > >> >ates/project/cordova/clean > >> >---------------------------------------------------------------------- > >> >diff --git a/bin/templates/project/cordova/clean > >> >b/bin/templates/project/cordova/clean > >> >index dc356d5..22a4e40 100755 > >> >--- a/bin/templates/project/cordova/clean > >> >+++ b/bin/templates/project/cordova/clean > >> >@@ -26,7 +26,7 @@ > >> > set -e > >> > > >> > XCODE_VER=$(xcodebuild -version | head -n 1 | sed -e 's/Xcode //') > >> >-XCODE_MIN_VERSION="4.5" > >> >+XCODE_MIN_VERSION="4.6" > >> > > >> > if [[ "$XCODE_VER" < "$XCODE_MIN_VERSION" ]]; then > >> > echo "Cordova can only run in Xcode version $XCODE_MIN_VERSION > >>or > >> >greater." > >> > > >> > > >> > >> > http://git-wip-us.apache.org/repos/asf/cordova-ios/blob/96557e3d/bin/temp > >>l > >> >ates/project/cordova/emulate > >> >---------------------------------------------------------------------- > >> >diff --git a/bin/templates/project/cordova/emulate > >> >b/bin/templates/project/cordova/emulate > >> >index be8f954..ef5848a 100755 > >> >--- a/bin/templates/project/cordova/emulate > >> >+++ b/bin/templates/project/cordova/emulate > >> >@@ -19,7 +19,7 @@ > >> > # > >> > > >> > XCODE_VER=$(xcodebuild -version | head -n 1 | sed -e 's/Xcode //') > >> >-XCODE_MIN_VERSION="4.5" > >> >+XCODE_MIN_VERSION="4.6" > >> > > >> > if [[ "$XCODE_VER" < "$XCODE_MIN_VERSION" ]]; then > >> > echo "Cordova can only run in Xcode version $XCODE_MIN_VERSION > >>or > >> >greater." > >> > > >> > > >> > >> > http://git-wip-us.apache.org/repos/asf/cordova-ios/blob/96557e3d/bin/temp > >>l > >> >ates/project/cordova/lib/install-emulator > >> >---------------------------------------------------------------------- > >> >diff --git a/bin/templates/project/cordova/lib/install-emulator > >> >b/bin/templates/project/cordova/lib/install-emulator > >> >index 70854dc..c8d6a14 100755 > >> >--- a/bin/templates/project/cordova/lib/install-emulator > >> >+++ b/bin/templates/project/cordova/lib/install-emulator > >> >@@ -83,7 +83,7 @@ case "$TARGET_LC" in > >> > esac > >> > > >> > XCODE_VER=$(xcodebuild -version | head -n 1 | sed -e 's/Xcode //') > >> >-XCODE_MIN_VERSION="4.5" > >> >+XCODE_MIN_VERSION="4.6" > >> > > >> > if [[ "$XCODE_VER" < "$XCODE_MIN_VERSION" ]]; then > >> > echo "Cordova can only run in Xcode version $XCODE_MIN_VERSION > >>or > >> >greater." > >> > > >> > > >> > >> > http://git-wip-us.apache.org/repos/asf/cordova-ios/blob/96557e3d/bin/temp > >>l > >> >ates/project/cordova/run > >> >---------------------------------------------------------------------- > >> >diff --git a/bin/templates/project/cordova/run > >> >b/bin/templates/project/cordova/run > >> >index b70da95..e1ef785 100755 > >> >--- a/bin/templates/project/cordova/run > >> >+++ b/bin/templates/project/cordova/run > >> >@@ -93,7 +93,7 @@ case "$TARGET_LC" in > >> > esac > >> > > >> > XCODE_VER=$(xcodebuild -version | head -n 1 | sed -e 's/Xcode //') > >> >-XCODE_MIN_VERSION="4.5" > >> >+XCODE_MIN_VERSION="4.6" > >> > > >> > if [[ "$XCODE_VER" < "$XCODE_MIN_VERSION" ]]; then > >> > echo "Cordova can only run in Xcode version $XCODE_MIN_VERSION > >>or > >> >greater." > >> > > >> > >> > >
