I haven't checked yet, but Andrew's guess is likely correct. I got those unit tests working *before* I started the whitelist work, but never went back to validate them afterwards.
I'll see what I can do to clean them up. I think I would like to keep some of those tests in place, as the code under test *is* all native code. On Fri, Aug 30, 2013 at 9:39 AM, Andrew Grieve <[email protected]> wrote: > My guess is that Ian broke these tests when he changed the whitelist to > behave the same way as Android's. He added whitelist unit tests to > mobile-spec, so likely these can just be deleted? Will let him confirm when > he gets in. > > > On Fri, Aug 30, 2013 at 9:16 AM, David Kemp <[email protected]> wrote: > > > Confirmed. I get 715 fails > > > > > > On Fri, Aug 30, 2013 at 4:45 AM, Shazron <[email protected]> wrote: > > > > > Can someone verify my results? I noticed there were changes in the code > > for > > > CDVWhitelist.m, and I was trying to fix static analyzer errors and > re-ran > > > the tests before and after I made the changes. > > > > > >
