Steve,
That's wonderful news. Can you mark CB-4902 as a dupe of CB-4889? I have
closed the pull requests.
Cheers,
Mike
On 2013-09-26 19:10, Steven Gill wrote:
Hey Michael,
I am not sure how that code got on master, but it shouldn't have been.
We have already taken care of this problem on the dev branch and I am in
the process of merging it today. Issue is at
https://issues.apache.org/jira/browse/CB-4889
Thanks for taking the time and sending pull requests.
The pull requests can be closed.
Cheers,
-Steve
On Thu, Sep 26, 2013 at 2:47 PM, Michael Gauthier <m...@silverorange.com>wrote:
Michal,
Awesome. I've sent in a signed copy of the CLA.
Cheers,
Mike
On 2013-09-26 18:02, Michal Mocny wrote:
Wow, this sounds like the problem I just ran into yesterday, so thanks for
fixing it. I'm heading out for today so cannot review&pull your patches,
but to get the ball rolling for tomorrow, make sure you have signed the
ICLA
(http://www.apache.org/**licenses/#clas<http://www.apache.org/licenses/#clas>)
since It looks like you have
not.
Thanks!
-Michal
On Thu, Sep 26, 2013 at 4:51 PM, Michael Gauthier <m...@silverorange.com
wrote:
Hi,
I opened this issue a couple of days ago:
https://issues.apache.org/****jira/browse/CB-4902<https://issues.apache.org/**jira/browse/CB-4902>
<https://**issues.apache.org/jira/browse/**CB-4902<https://issues.apache.org/jira/browse/CB-4902>
The issue was the plugin identifiers were changed and the code wasn't
updated with the new identifiers. I opened two pull requests to fix the
issue but I can't figure out how to add them the to the Jira Issue.
Can someone take a look and approve/reject them?
https://github.com/apache/****cordova-plugin-file/pull/6<https://github.com/apache/**cordova-plugin-file/pull/6>
<htt**ps://github.com/apache/**cordova-plugin-file/pull/6<https://github.com/apache/cordova-plugin-file/pull/6>
https://github.com/apache/****cordova-plugin-file-transfer/****pull/7<https://github.com/apache/**cordova-plugin-file-transfer/**pull/7>
<https://github.com/**apache/cordova-plugin-file-**transfer/pull/7<https://github.com/apache/cordova-plugin-file-transfer/pull/7>
Thanks,
Mike
