----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14681/#review27125 -----------------------------------------------------------
Ship it! Ship It! - Braden Shepherdson On Oct. 16, 2013, 9:27 p.m., Mark Koudritsky wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14681/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2013, 9:27 p.m.) > > > Review request for cordova. > > > Bugs: CB-4748 > https://issues.apache.org/jira/browse/CB-4748 > > > Repository: cordova-cli > > > Description > ------- > > CB-4748: Fail quickly if dir passed to cordova create is not empty. > This change also exists as: https://github.com/apache/cordova-cli/pull/55 > > > Also add cfg parameter to create() for extra configuration which saved in > .cordova/config.json > Should come together with the corresponding change in mca.js: > https://github.com/MobileChromeApps/mobile-chrome-apps/pull/25 > > > Diffs > ----- > > src/create.js 4b2b950 > > Diff: https://reviews.apache.org/r/14681/diff/ > > > Testing > ------- > > ./mca.js create io.some.app2 > > > Thanks, > > Mark Koudritsky > >