> On Oct. 18, 2013, 2:09 p.m., Braden Shepherdson wrote: > > Better is probably to switch to child_process.spawn instead, using the > > option stdio: 'inherit' if we're in --verbose mode, and stdio: 'ignore' > > when not verbose. That avoids buffering the output altogether, which we > > don't really want anyway.
I looked at spawn before submitting pull request, I just assumed there was a good reason for using exec vs. spawn. Yes I agree spwan is better and less prone to surface bugs in the future if output from child is larger than current maxBuffer being set - Carlos ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14733/#review27193 ----------------------------------------------------------- On Oct. 18, 2013, 4:34 a.m., Carlos Santana wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14733/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2013, 4:34 a.m.) > > > Review request for cordova. > > > Repository: cordova-cli > > > Description > ------- > > CB-5125 cordova-cli compile emulate build broken > > > Diffs > ----- > > src/compile.js 34c24fe8e66d477d74728e018c250cf5e267c351 > src/emulate.js cd4c038a3c2125224d25715a3fc2cf3b9e9f3cb0 > src/run.js dddc1fc6f7a168267decdb3f6d8c4471d3480893 > > Diff: https://reviews.apache.org/r/14733/diff/ > > > Testing > ------- > > > Thanks, > > Carlos Santana > >
