+1 to CB-1234:[ios] syntax
On Fri, Oct 18, 2013 at 10:39 AM, Ian Clelland <iclell...@chromium.org>wrote: > One of the git tools will discard the bracketed items if they appear at the > beginning of the commit description (I think it's git-am, because it is > intended to apply patches from mailboxes, where messages often start with > "[mailing-list-name]", which is just noise.) > > Either > CB-1234: [ios] Fix the thing > or > CB-1234: ios: Fix the thing > > should work fine, though. > > +1/2 from me for each of them. I think it's a good idea to put the platform > in the commit, if it only affects that platform's code. It lets you filter > the git-log output when you're scanning for changes. Leave it out if it > touches the common JS, though. > > Ian > > > On Fri, Oct 18, 2013 at 1:09 PM, Shazron <shaz...@gmail.com> wrote: > > > There was a discussion earlier about removing the square brackets because > > it did something funny with some tool, so I would remove the square > > brackets. > > > > > > On Thu, Oct 17, 2013 at 7:41 PM, lmnbeyond <lmnbey...@gmail.com> wrote: > > > > > Hi guys, > > > > > > Since plugin-related code are all grouped into its own repo, should > > we > > > add platform info in commit messages? I think it would be more clear > when > > > we view the commit history. > > > > > > e.g., > > > > > > [CB-1234][iOS] Fix… > > > [CB-5678][all] Fix… > > > [Android]… > > > [js]… > > > > > > What do you think, guys? > > > > > > > > > Best Regards! > > > > > > > > > > > > > > >
