I'll add the check whenever someone goes to the Keyboard manual test page. Will re-visit once the cordova-plugins repo is up.
On Wed, Oct 30, 2013 at 4:14 PM, Michal Mocny <mmo...@chromium.org> wrote: > After discussing with shaz, seems there is no good solution which does not > involve action on the users' part, except to just be explicit about remote > url. > > Instead, I think we are going to just remove the hard dependency, and have > those mobile-spec tests fail unless you manually install the plugin. Since > there are no auto-tests for it, its fine. Once we find the plugin a repo, > we can add a local dependency for it. > > Side note: part of the problem stems from the fact that the mobile-spec > dependency plugin sucks. Its hard coded to look in the parent directory, > instead of just running the tests for whichever plugin happens to be > installed however/wherever it was installed from. > > -Michal > > > On Wed, Oct 30, 2013 at 3:47 PM, Michal Mocny <mmo...@chromium.org> wrote: > > > The way we define dependencies is the problem. The plugin author is > > currently responsible for defining explicitly the location of the plugin > to > > fetch, instead of just the id&version and letting the system do its job. > > > > Andrew had a proposal in the past for a simple form of "local plugin > > repository" that just used the local fs in a clever way. Then, you could > > add its id as a dependency even when its not in the public plugin > registry, > > and expect that mobile-spec from-master-branch to add a local mapping. > > > > Not sure if that work has even started, though. > > > > -Michal > > > > > > On Wed, Oct 30, 2013 at 1:58 PM, Brian LeRoux <b...@brian.io> wrote: > > > >> I'm not a very big fan of this sub directory business anyhow. Too many > >> ways > >> to fail. It would be better, in my mind, if we aimed to always have one > >> repo equals one package. > >> > >> > >> On Wed, Oct 30, 2013 at 10:40 AM, Shazron <shaz...@gmail.com> wrote: > >> > >> > if we had the cordova-plugins repo created, this won't be a problem. > The > >> > issue is not resolved yet: > >> > https://issues.apache.org/jira/browse/INFRA-6902 > >> > > >> > > >> > On Wed, Oct 30, 2013 at 1:38 PM, Shazron <shaz...@gmail.com> wrote: > >> > > >> > > It's checked into master (not in 3.2.x branch yet until this issue > >> below > >> > > is resolved). > >> > > > >> > > Should I add it in the dependency plugin? > >> > > > >> > > The problem is I have to add it as a url, not from a local repo > (thus > >> > > install requires an internet connection). > >> > > > >> > > This is because we can't switch to a branch _and_ a subdir of a > local > >> > repo > >> > > (this is not a feature of the dependency tag). > >> > > > >> > > >> > > > > >
