+1 We need to focus more on making sure tests pass on windows and mac as we make changes.
On Thu, Nov 7, 2013 at 4:22 PM, Jesse <purplecabb...@gmail.com> wrote: > tests should be passing now. This is related to the fact that wp7/8 and > windows8 don't consider repo root to be platform root. > > It may make sense to to add another field to the platform objects to > specify this, but I simply modified the tests to allow for it. > > Incidentally, these tests would be much more useful if they worked on > windows. I unfortunately cannot manage wp7+wp8+windows8 and keep the > cli+tests up to date. Things are getting better with Sergey active and some > support from Steve, Tim and Carlos, but generally I think we should all be > able to jump onto a windows box and test/fix some stuff. As apache > contributors, everyone has an msdn subscription already. > > > > > @purplecabbage > risingj.com > > > On Thu, Nov 7, 2013 at 7:46 AM, David Kemp <drk...@chromium.org> wrote: > > > last error output from npm test of CLI: > > > > > > Failures: > > > > 1) platform command success `add` should shell out to specified > > platform's bin/create, using the version that is specified in > > platforms manifest > > Message: > > [31mExpected '"lib/wp/cordova/3.1.0/wp8/wp8/bin/create" > > "some/path/platforms/wp8" "ca.filmaj.id" "magical mystery tour"' to > > match /lib.wp.cordova.\d.\d.\d[\d\w\-]*.wp8.bin.create/gi. [0m > > Stacktrace: > > Error: Expected '"lib/wp/cordova/3.1.0/wp8/wp8/bin/create" > > "some/path/platforms/wp8" "ca.filmaj.id" "magical mystery tour"' to > > match /lib.wp.cordova.\d.\d.\d[\d\w\-]*.wp8.bin.create/gi. > > at new jasmine.ExpectationResult > > > > > (/Users/drkemp/buildbot/slave_common/Tools_CLI/build/cordova-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:114:32) > > at null.toMatch > > > > > (/Users/drkemp/buildbot/slave_common/Tools_CLI/build/cordova-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:1235:29) > > at > > > /Users/drkemp/buildbot/slave_common/Tools_CLI/build/cordova-cli/spec/platform.spec.js:150:57 > > at _fulfilled > > > > > (/Users/drkemp/buildbot/slave_common/Tools_CLI/build/cordova-cli/node_modules/q/q.js:798:54) > > at self.promiseDispatch.done > > > > > (/Users/drkemp/buildbot/slave_common/Tools_CLI/build/cordova-cli/node_modules/q/q.js:827:30) > > at Promise.promise.promiseDispatch > > > > > (/Users/drkemp/buildbot/slave_common/Tools_CLI/build/cordova-cli/node_modules/q/q.js:760:13) > > at > > > /Users/drkemp/buildbot/slave_common/Tools_CLI/build/cordova-cli/node_modules/q/q.js:574:44 > > at flush > > > (/Users/drkemp/buildbot/slave_common/Tools_CLI/build/cordova-cli/node_modules/q/q.js:108:17) > > at process._tickCallback (node.js:415:13) > > > > 2) platform command success `add` should shell out to specified > > platform's bin/create, using the version that is specified in > > platforms manifest > > Message: > > [31mExpected > > '"lib/windows8/cordova/3.1.0/windows8/windows8/bin/create" > > "some/path/platforms/windows8" "ca.filmaj.id" "magical mystery tour"' > > to match /lib.windows8.cordova.\d.\d.\d[\d\w\-]*.windows8.bin.create/gi. > > [0m > > Stacktrace: > > Error: Expected > > '"lib/windows8/cordova/3.1.0/windows8/windows8/bin/create" > > "some/path/platforms/windows8" "ca.filmaj.id" "magical mystery tour"' > > to match /lib.windows8.cordova.\d.\d.\d[\d\w\-]*.windows8.bin.create/gi. > > at new jasmine.ExpectationResult > > > > > (/Users/drkemp/buildbot/slave_common/Tools_CLI/build/cordova-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:114:32) > > at null.toMatch > > > > > (/Users/drkemp/buildbot/slave_common/Tools_CLI/build/cordova-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:1235:29) > > at > > > /Users/drkemp/buildbot/slave_common/Tools_CLI/build/cordova-cli/spec/platform.spec.js:155:57 > > at _fulfilled > > > > > (/Users/drkemp/buildbot/slave_common/Tools_CLI/build/cordova-cli/node_modules/q/q.js:798:54) > > at self.promiseDispatch.done > > > > > (/Users/drkemp/buildbot/slave_common/Tools_CLI/build/cordova-cli/node_modules/q/q.js:827:30) > > at Promise.promise.promiseDispatch > > > > > (/Users/drkemp/buildbot/slave_common/Tools_CLI/build/cordova-cli/node_modules/q/q.js:760:13) > > at > > > /Users/drkemp/buildbot/slave_common/Tools_CLI/build/cordova-cli/node_modules/q/q.js:574:44 > > at flush > > > (/Users/drkemp/buildbot/slave_common/Tools_CLI/build/cordova-cli/node_modules/q/q.js:108:17) > > at process._tickCallback (node.js:415:13) > > > > 3) platform command success `add` should call into lazy_load.custom > > if there is a user-specified configruation for consuming custom > > libraries > > Message: > > [31mExpected '"lib/wp/phonegap/bleeding edge/wp8/wp8/bin/create" > > "some/path/platforms/wp8" "ca.filmaj.id" "magical mystery tour"' to > > match /lib.wp.phonegap.bleeding edge.wp8.bin.create/gi. [0m > > Stacktrace: > > Error: Expected '"lib/wp/phonegap/bleeding > > edge/wp8/wp8/bin/create" "some/path/platforms/wp8" "ca.filmaj.id" > > "magical mystery tour"' to match /lib.wp.phonegap.bleeding > > edge.wp8.bin.create/gi. > > at new jasmine.ExpectationResult > > > > > (/Users/drkemp/buildbot/slave_common/Tools_CLI/build/cordova-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:114:32) > > at null.toMatch > > > > > (/Users/drkemp/buildbot/slave_common/Tools_CLI/build/cordova-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:1235:29) > > at > > > /Users/drkemp/buildbot/slave_common/Tools_CLI/build/cordova-cli/spec/platform.spec.js:173:57 > > at _fulfilled > > > > > (/Users/drkemp/buildbot/slave_common/Tools_CLI/build/cordova-cli/node_modules/q/q.js:798:54) > > at self.promiseDispatch.done > > > > > (/Users/drkemp/buildbot/slave_common/Tools_CLI/build/cordova-cli/node_modules/q/q.js:827:30) > > at Promise.promise.promiseDispatch > > > > > (/Users/drkemp/buildbot/slave_common/Tools_CLI/build/cordova-cli/node_modules/q/q.js:760:13) > > at > > > /Users/drkemp/buildbot/slave_common/Tools_CLI/build/cordova-cli/node_modules/q/q.js:574:44 > > at flush > > > (/Users/drkemp/buildbot/slave_common/Tools_CLI/build/cordova-cli/node_modules/q/q.js:108:17) > > at process._tickCallback (node.js:415:13) > > >
