Whoops, I also meant to say, those LGTM, especially the first one. Much more detailed docs for CLI are very welcome.
Braden On Wed, Nov 20, 2013 at 1:20 PM, Braden Shepherdson <[email protected]>wrote: > Reviewboard was giving Mark problems last week, too. Pull requests are > more convenient with the exception that they send emails on every comment, > rather than buffering them until you submit the review. One of the Github's > oldest outstanding requests, etc. etc. > > Braden > > > On Wed, Nov 20, 2013 at 12:21 PM, Mike Billau <[email protected]>wrote: > >> Hello, >> >> Can somebody please review these two documentation pull requests? >> >> https://github.com/apache/cordova-docs/pull/140 >> https://github.com/apache/cordova-docs/pull/149 >> >> I'd like to merge them pretty soon - I guess I can do this on my own based >> on silent consensus. >> >> Also, I tried to use the reviewboard, but every time I'd upload a diff or >> use the tools, reviewboard would prepend the letter "r" to one of the >> hashes in one of my files. This caused the review tool to reject the diff >> since it couldn't match the file and hash. Anybody have any experience >> with >> this? >> >> Thanks, >> Mike Billau >> > >
