----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15750/#review29208 -----------------------------------------------------------
The documentation should probably be clear that 'custom="false"' will *also* designate a custom framework -- I suspect that some people will try that, rather than simply removing the attribute. Also, what happens if two plugins depend on the same framework? It looks like uninstalling either of them will remove the framework, but I'm not certain. - Ian Clelland On Nov. 21, 2013, 3:26 a.m., Anis Kadri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15750/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2013, 3:26 a.m.) > > > Review request for cordova, Max Woghiren and Braden Shepherdson. > > > Bugs: CB-5238 > https://issues.apache.org/jira/browse/CB-5238 > > > Repository: cordova-plugman > > > Description > ------- > > Adding/Removing custom frameworks to iOS projects > > node-xcode 0.6.3 needs to be pushed to npm for this to be tested. > > Custom frameworks can be defined in plugin.xml like so: > > <framework src="src/ios/Custom.framework" custom="true"> > > if @custom="true" is not defined, plugman will think it is a System framework > and will therefore fail to add it properly. > > > Diffs > ----- > > spec/platforms/ios.spec.js cb7460d > spec/plugins/ChildBrowser/plugin.xml 512c02f > spec/plugins/DummyPlugin/plugin.xml fad5072 > spec/plugins/FaultyPlugin/plugin.xml 30af6e7 > spec/util/config-changes.spec.js 5e46b69 > src/install.js c0a4de9 > src/platforms/ios.js 065c4a7 > src/uninstall.js 11ff7fb > src/util/config-changes.js 0239b61 > > Diff: https://reviews.apache.org/r/15750/diff/ > > > Testing > ------- > > > Thanks, > > Anis Kadri > >
