On Tue, Nov 26, 2013 at 12:09 PM, Brian LeRoux <[email protected]> wrote:
> You should download the binary for the user in the script. Node has a cross > platform http lib. > > > On Tue, Nov 26, 2013 at 10:00 AM, Naik, Archana <[email protected]> wrote: > > > Thank you Steven for doing this!! > > > > CLI & Plugman are both on a fireos branch. They both require more work. > > > > CLI -> firstly I had to manually download amazon webview sdk and copy it > > into my cordova-amazon-fireos directory that got lazy loaded. This is not > > an ideal workflow but it was documented well so meh. > > > > [AN] : Yes, that's by design for now. If you have better ideas please let > > me know and I will look into it. > > > Brian made a good suggestion. > > Secondly, it is sitll > > failing to install for me. I need to spend a bit more time to figure out > > why. > > > > > > [AN]: CLI is failing because of the repo URL. Currently, its pointing to > > Github URL. I will change it to apache one and it should fix the problem. > > > On the fireos branch for cordova-cli, I have set it to pull from apache and not github. That is not the issue. I am investigating now what the issue is. > > Plugman -> tests aren't loading properly for fireos. > > > > > > [AN]: HmmŠI am pretty sure I ran "npm test" and it was fine. Any > > particular branch or all of them are failing of ryou? > > > When I run npm test on the fireos branch for plugman, I get the following error: Exception loading: /Users/stevengill/Documents/repo/cordova/cordova-coho/cordova-plugman/spec/platforms/amazon-fireos.spec.js [TypeError: Cannot call method 'findall' of null] After this message, the rest of the plugman tests run and pass. > > CordovaJS -> Do you have a pull request for this? Just using Androids? > > > > > > [AN]: I have the repo ready with fireos changes. I will send the pull > > request soon. > > > Sounds good. > > Thanks again, > > Archana > > > > On 11/25/13 5:11 PM, "Steven Gill" <[email protected]> wrote: > > > > >So I have gone ahead and merged in your changes for the CLI, Plugman and > > >cordova-amazon-fireos into the apache repos. Cordova-amazon-fireos repos > > >has no history currently and I am not planning on spending anymore time > > >trying to migrate it over. > > > > > >CLI & Plugman are both on a fireos branch. They both require more work. > > > > > >CLI -> firstly I had to manually download amazon webview sdk and copy it > > >into my cordova-amazon-fireos directory that got lazy loaded. This is > not > > >an ideal workflow but it was documented well so meh. Secondly, it is > sitll > > >failing to install for me. I need to spend a bit more time to figure out > > >why. > > > > > >Plugman -> tests aren't loading properly for fireos. > > > > > >Plugins -> I will be looking into these tomorrow. > > > > > >CordovaJS -> Do you have a pull request for this? Just using Androids? > > > > > > > > > > > > > > >On Mon, Nov 25, 2013 at 11:15 AM, Steven Gill > > ><[email protected]>wrote: > > > > > >> Sure can! I plan on merging fireos + ubuntu for the next release. Will > > >>get > > >> on that today. > > >> > > >> > > >> On Mon, Nov 25, 2013 at 9:45 AM, Naik, Archana <[email protected]> > > wrote: > > >> > > >>> Congratulations guys!! > > >>> > > >>> Hi, Steven > > >>> > > >>> Now that this release is out, is there any chance you or someone > could > > >>> look at cordova-amazon-fireos repo problem? Would love to have the > port > > >>> merged before next release. > > >>> > > >>> Thanks for your help. > > >>> Archana > > >>> > > >> > > >> > > > > >
