Revert them out if you like, that's the right flow for broken commits. There's no need for a lecture on not checking in broken code - it wasn't broken on our machines!
Braden On Wed, Nov 27, 2013 at 1:36 PM, Steven Gill <[email protected]> wrote: > I see it is easy to fix by changing npm test to not run e2e tests. The > issue here is that this code should never have made it to master while > broken. I am going to revert the e2e tests out and they can be resubmitted > on a branch and merged in when ready. We all need to be diligent in making > sure broken code never makes it to master! > > > On Wed, Nov 27, 2013 at 1:25 PM, Jesse <[email protected]> wrote: > > > they all live in their own folder, so it is easy to run tests without > > running e2e tests. ( ie we do at least have some good separation ) > > Just modify package.json 's scripts{test:} to not include e2e/ until they > > are fixed. > > > > @purplecabbage > > risingj.com > > > > > > On Wed, Nov 27, 2013 at 1:20 PM, Lorin Beer <[email protected] > > >wrote: > > > > > +1 on reverting these out. Pushing large commits that causes widespread > > > failing tests on one or more platforms should be reverted out. They > > should > > > not be pushed up to master in the first place. > > > > > > > > > On Wed, Nov 27, 2013 at 1:16 PM, Steven Gill <[email protected]> > > > wrote: > > > > > > > I think we should revert these out and put them on a branch until > > ready. > > > > > > > > Thoughts? > > > > > > > > > > > > On Wed, Nov 27, 2013 at 12:59 PM, Jesse <[email protected]> > > wrote: > > > > > > > > > okay, yeah, just switched over to OSX, and there are numerous (59) > > > > failures > > > > > here too as well. > > > > > > > > > > I have verified that these are all a result of the e2e tests > folder, > > if > > > > you > > > > > run : > > > > > jasmine-node --color spec > > > > > > > > > > You will not see any of these failures. > > > > > > > > > > blame @mmocny ;) > > > > > > > > > > > > > > > @purplecabbage > > > > > risingj.com > > > > > > > > > > > > > > > On Wed, Nov 27, 2013 at 12:44 PM, David Kemp <[email protected]> > > > > wrote: > > > > > > > > > > > a recent set of commits landed about 1/2 hour ago has broken the > > CLI > > > > > tests > > > > > > > > > > > > 343 tests, 572 assertions, 59 failures > > > > > > > > > > > > > > > > > > looks like most are : Error: ENOENT, no such file or directory > > > > > > > > > > > > > > > > > > > > >
