----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15889/#review29517 -----------------------------------------------------------
src/metadata/android_parser.js <https://reviews.apache.org/r/15889/#comment56830> This is duplicating the logic in the lazy loader for checking for custom configs and so on. The correct flow is: lazy_load.based_on_config(project_root, 'android').then(function(lib_path) { // shell out to lib_path/bin/check_reqs }); - Braden Shepherdson On Nov. 27, 2013, 9:51 p.m., Michal Mocny wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15889/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2013, 9:51 p.m.) > > > Review request for cordova. > > > Repository: cordova-cli > > > Description > ------- > > . > > > Diffs > ----- > > src/metadata/android_parser.js 535d5b2 > > Diff: https://reviews.apache.org/r/15889/diff/ > > > Testing > ------- > > > Thanks, > > Michal Mocny > >
