----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15914/ -----------------------------------------------------------
Review request for cordova. Repository: cordova-cli Description ------- There were two problems. 1. Couldn't delete the tmp project dir on Windows because it was the CWD of the node process and Windows can't delete "busy" dirs. 2. There was an interaction between tests in spec and those in e2e. Jasmine ran the e2e tests first, the CWD stayed in temp dir, but some tests in spec assume that CWD is the cordova source root dir. Both problems solved by process.chdir(<source root>) after each e2e test. But probably the spec tests should also be fixed, because counting on specific CWD is fragile. Diffs ----- e2e/create.spec.js 5900d7a e2e/platform.spec.js 879a909 e2e/plugin.spec.js 0425f90 Diff: https://reviews.apache.org/r/15914/diff/ Testing ------- Thanks, Mark Koudritsky