----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16701/#review31313 -----------------------------------------------------------
src/fetch.js <https://reviews.apache.org/r/16701/#comment59772> This section would be better simply as: return p.then(... - Braden Shepherdson On Jan. 7, 2014, 9:41 p.m., Mark Koudritsky wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16701/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2014, 9:41 p.m.) > > > Review request for cordova. > > > Bugs: CB-5006 > https://issues.apache.org/jira/browse/CB-5006 > > > Repository: cordova-plugman > > > Description > ------- > > The diff here is missing author info and squashes 2 commits together, for > properly formatted patch use: > curl https://github.com/kamrik/cordova-plugman/compare/searchpath.patch | git > am > > Add --searchpath option for local plugin search path. > The param accepts a colon separated list of dirs that are searched in order > for subdirs containing a plugin.xml file with the requested plugin ID. > > > Diffs > ----- > > doc/help.txt 0c6ad7a > main.js 5fa6422 > plugman.js a7ff484 > src/fetch.js 0d50187 > src/install.js 6b09434 > > Diff: https://reviews.apache.org/r/16701/diff/ > > > Testing > ------- > > npm test; > > plugman install --platform android --project > /.../myproject/platforms/android --plugin org.apache.cordova.file > plugman uninstall --platform android --project > /.../myproject/platforms/android --plugin org.apache.cordova.file > plugman install --platform android --project > /.../myproject/platforms/android --plugin org.apache.cordova.file \ > --searchpath /some_real/local_reg:/some/dummy/path > > cordova create MyApp > cd MyApp > cordova plugin add org.apache.cordova.file > > > Thanks, > > Mark Koudritsky > >
