----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17264/#review32719 -----------------------------------------------------------
Ship it! LGTM! I'll merge it in. - Andrew Grieve On Jan. 23, 2014, 9:02 p.m., Mark Koudritsky wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17264/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2014, 9:02 p.m.) > > > Review request for cordova. > > > Bugs: CB-5493 > https://issues.apache.org/jira/browse/CB-5493 > > > Repository: cordova-cli > > > Description > ------- > > Same diff on github https://github.com/kamrik/cordova-cli/compare/lazy_tmp > > If "cordova create" is interrupted with Ctrl-C while downloading the cordova > library for www, a bad version is stored in ~/.cordova/lib/. That bad version > is then used for future runs of "cordova create" which results in projects > with > www dir containing no files except a subfolder named like > cordova-app-hello-world-3.2.0-ee9a86g3 > > With this change lazy_load will do everything in a temp dir and only move to > the > final destination as one of the last steps. > > > Diffs > ----- > > src/lazy_load.js 6de1f7c > > Diff: https://reviews.apache.org/r/17264/diff/ > > > Testing > ------- > > npm test > cordova create tst > crodova platform add android > > > Thanks, > > Mark Koudritsky > >
