Would love to move this along. Would like to get buy-in from others
first though.
The proposal in this PR is to add tags like:
<icon id="icon" src="icon.png" />
<icon id="logo" src="logo.png" width="255" height="255" />
<icon src="logo-android.png" width="255" height="255"
cdv:platform="android" cdv:density="mdpi" />
My feedback:
- What is "id" for?
- Supporting "cdv:platform" is fine, but we should also support just
"platform=". I'd be fine to drop xmlns="http://www.w3.org/ns/widgets";
from the file.
- I don't think there are any platforms that support non-square icons.
I think size="###" would be better than width= && height=
- What happens if you don't specify a size? Do we sniff it from the
png header? This might be nice as a follow-up, but I'd lean towards
making it required for the first cut.
- cdv:density seems redundant with respect to size. Icons on android
are 46px at mdpi, so the size can be used to derive the density.
On Mon, Feb 10, 2014 at 10:55 AM, Andrew Grieve <agri...@chromium.org> wrote:
> He Axel, thanks for spearheading this. Will have a look shortly.
>
>
> On Mon, Feb 10, 2014 at 9:07 AM, Axel Nennker <ignisvul...@gmail.com> wrote:
>>
>> Andrew,
>>
>> any comments to the current implementation?
>> https://github.com/apache/cordova-cli/pull/126
>>
>> Joe commented that the new class in config_parser.js named "icon" should
>> be named "Icon" but I left it as is because the other classes are lowercase
>> too.
>> There was another comment that namespaces in config.xml attributes are
>> SchnickSchnack/chatter.
>> I think that we should use the cordava namespace if config.xml deviates
>> from the W3C widget definition.
>> These two are the only comments I got.
>>
>> I tested this on Android and FirefoxOS.
>>
>> Any chance to accept the request (at least the Android part)?
>>
>> -Axel
>>
>
