+1 -James Jong On Feb 26, 2014, at 9:45 AM, Ian Clelland <iclell...@chromium.org> wrote:
> A couple of points: > > -- The signature is good, and the hashes match the released zip file. I > can't reconstruct the enclosed zip files exactly from the repositories, but > I can compare their contents. (I can get close, but it seems that either > file dates are enough to throw off the compression, or my zip binary is > just different than the one Steven used at the time.) > > -- cordova-docs does not match the released tag. It appears to have been > build from hash db65dd69cbf4c967c27e0ed1994de90e6e244e25, with the 2.8.0rc1 > docs removed. (I can reproduce it exactly by cherry-picking commit bb95107 > on top of that hash.) If possible, I'd like to create a 2.8.1 tag in the > cordova-docs repo at a commit that matches these docs. > > -- cordova-osx is also included in this archive. It matches tag 2.8.0 at > hash f025cc06165a9aec9d7bccddd9ae03b3fbf8e4ab. Cordova-osx was > unfortunately missing a top-level LICENSE file, but all of the source > artifacts contain the proper license header, and the whole project is > enclosed in a zip file which *does* contain that license in full. > > -- cordova-wp7 is also included in this archive. Coho is no longer capable > of cloning this one. :( However, it matches the repository at > https://git-wip-us.apache.org/repos/asf/cordova-wp7.git on tag 2.8.0 at > hash 8ac37396354ee5764898179dd35f0eed2e82e271 > > > +1 to this release, warts and all. > > > On Tue, Feb 25, 2014 at 10:40 PM, Bryan Higgins <br...@bryanhiggins.net>wrote: > >> +1 >> >> >> On Tue, Feb 25, 2014 at 4:55 PM, RUDD, Brett <brettr...@gmail.com> wrote: >> >>> +1 >>> >>> On Feb 25, 2014, at 13:21, Steven Gill <stevengil...@gmail.com> wrote: >>> >>>> 2.8.0 did. Figured might as well do the point release too >>>> On Feb 25, 2014 1:18 PM, "Joe Bowser" <bows...@gmail.com> wrote: >>>> >>>>> +1 - This release had a vote, didn't it? >>>>> >>>>> On Tue, Feb 25, 2014 at 12:20 PM, Lorin Beer < >> lorin.beer....@gmail.com> >>>>> wrote: >>>>>> +1 >>>>>> >>>>>> >>>>>> On Tue, Feb 25, 2014 at 12:03 PM, Steven Gill < >> stevengil...@gmail.com >>>>>> wrote: >>>>>> >>>>>>> Please review and vote on our past release of Cordova 2.8.1. >>>>>>> >>>>>>> You can find the src + asc + md5 + sha at the following links: >>>>>>> * http://archive.apache.org/dist/cordova/cordova-2.8.1-src.zip >>>>>>> * http://archive.apache.org/dist/cordova/cordova-2.8.1-src.zip.asc >>>>>>> * http://archive.apache.org/dist/cordova/cordova-2.8.1-src.zip.md5 >>>>>>> * http://archive.apache.org/dist/cordova/cordova-2.8.1-src.zip.sha >>>>>>> >>>>>>> The 2.8.1 tag was only applied to Android >>>>>>> >>>>>>> >>>>> >>> >> http://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=shortlog;h=refs/tags/2.8.1 >>>>>>> d8c755b95a85de95c51768a271aa2747bb5467b9 refs/tags/2.8.1 >>>>>>> >>>>>>> The 2.8.0 tag was used for other platforms >>>>>>> >>>>>>> >>>>> >>> >> http://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;a=shortlog;h=refs/tags/2.8.0 >>>>>>> f93f7a5bad8b7f9d141852c8b1f369a262f0389e refs/tags/2.8.0 >>>>>>> >>>>>>> >>>>> >>> >> http://git-wip-us.apache.org/repos/asf?p=cordova-blackberry.git;a=shortlog;h=refs/tags/2.8.0 >>>>>>> a297ff557b93c30427a113af80620221c8a74f40 refs/tags/2.8.0 >>>>>>> >>>>>>> >>>>> >>> >> http://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;a=shortlog;h=refs/tags/2.8.0 >>>>>>> 326130a182e5cd2d391e942efdf961cc6fa34040 refs/tags/2.8.0 >>>>>>> >>>>>>> >>>>> >>> >> http://git-wip-us.apache.org/repos/asf?p=cordova-wp8.git;a=shortlog;h=refs/tags/2.8.0 >>>>>>> 9176a0238c26ea1fd5edfe2e2b052607aca1b9ac refs/tags/2.8.0 >>>>>>> >>>>>>> >>>>> >>> >> http://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;a=shortlog;h=refs/tags/2.8.0 >>>>>>> a2f158653f533ebbb5dfbfe136bfdf9e1a57f01c refs/tags/2.8.0 >>>>>>> >>>>>>> >>>>> >>> >> http://git-wip-us.apache.org/repos/asf?p=cordova-js.git;a=shortlog;h=refs/tags/2.8.0 >>>>>>> 6208c9593a0a472f3e04168c9d237a3121329c1a refs/tags/2.8.0 >>>>>>> >>>>>>> >>>>> >>> >> http://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;a=shortlog;h=refs/tags/2.8.0 >>>>>>> 4fdfaad8fed1ea52bea5401ee1e1d2099d94f446 refs/tags/2.8.0 >>>>>>> >>>>>>> >>>>> >>> >> http://git-wip-us.apache.org/repos/asf?p=cordova-app-hello-world.git;a=shortlog;h=refs/tags/2.8.0 >>>>>>> 366f9843eb3d2172986d18cf370323ddd35117b8 refs/tags/2.8.0 >>>>>>> >>>>>>> >>>>> >>> >> http://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;a=shortlog;h=refs/tags/2.8.0 >>>>>>> c222b586d286d2dd3a7ba67259d05d5f60e51d8f refs/tags/2.8.0 >>>>>>> >>>>>>> Voting will go on for 48 hours. >>>>>>> >>>>> >>> >>> >>