Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-cli/pull/161#issuecomment-40355369
LGTM + Tested.
I think we should accept the changes and then look on the following
improvements:
1. The line below is very complex to read/understand. Move to separate fn +
simplify + comments?
[['/s', '/c', '"'+[cmd].concat(args).map(function(a){if (/^[^"].*
.*[^"]/.test(a)) return '"'+a+'"'; return a;}).join(" ")+'"'].join(" ")];
2. Not sure we should use two different cases - if there is white space and
not. Single case is preferred since we don't need to test both cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
