Github user fardjad commented on a diff in the pull request:

    https://github.com/apache/cordova-cli/pull/164#discussion_r11925780
  
    --- Diff: src/metadata/android_parser.js ---
    @@ -97,6 +108,29 @@ module.exports.prototype = {
                 }
             }
     
    +        // Set launchMode in AndroidManifest
    +        var launchModePref = this.findLaunchModePreference(config);
    +        if (launchModePref) {
    +            var act = manifest.getroot().find('./application/activity');
    +            switch (launchModePref) {
    +                case 'standard':
    +                    act.attrib["android:launchMode"] = 'standard';
    +                    break;
    +                case 'singleTop':
    +                    act.attrib["android:launchMode"] = 'singleTop';
    +                    break;
    +                case 'singleTask':
    +                    act.attrib["android:launchMode"] = 'singleTask';
    +                    break;
    +                case 'singleInstance':
    +                    act.attrib["android:launchMode"] = 'singleInstance';
    +                    break;
    +                case 'default':
    +                    delete act.attrib["android:launchMode"];
    --- End diff --
    
    OK, so I'll change that **switch** statement to **if** and amend this 
commit. Then I'll add the default `launch-mode` preference to **default.xml** 
and submit a pull request to **cordova-android** repository.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to