How about: trivial = < 10 lines || commit hash exists in a trivial-commits.txt file?
On Fri, Apr 25, 2014 at 3:42 PM, Jesse <[email protected]> wrote: > We can accept trivial commits without an ICLA, so the commit hook would > need a firm definition of 'trivial'. > Sounds like more work than it is worth, I would rather leave the definition > of 'trivial' to the reviewer of the pull request. > > @purplecabbage > risingj.com > > > On Fri, Apr 25, 2014 at 12:37 PM, Marcel Kinard <[email protected]> > wrote: > > > This sounds to me like the simplest approach. > > > > Would a git commit hook catch this scenario so a commit never goes in > > without ICLA verification? Even if a non-ICLA author's commit can be > > reverted, that content is still in the repo, which doesn't sound idea. > > > > On Apr 25, 2014, at 3:31 PM, Andrew Grieve <[email protected]> wrote: > > > > > Instead of having a map of username -> Real Name, we could maintain a > > list > > > of usernames that we know have a valid ICLA. > > > > >
