The common JS for resolveLocalFileSystemURI and resolveLocalFileSystemURL both call exec with resolveLocalFileSystemURL [1]
resolveLocalFileSystemURI is the new implementation [2] which handles the exec call [3] rather than clobbering the window object [1] https://github.com/apache/cordova-plugin-file/blob/master/www/resolveLocalFileSystemURI.js#L64-L69 [2] https://github.com/blackberry-webworks/cordova-plugin-file/blob/b7ba108f08b90ead2efb55bd40e1215fdde10cca/www/blackberry10/resolveLocalFileSystemURI.js [3] https://github.com/blackberry-webworks/cordova-plugin-file/blob/b7ba108f08b90ead2efb55bd40e1215fdde10cca/www/blackberry10/FileProxy.js#L43 On Mon, May 5, 2014 at 10:29 AM, Ian Clelland <[email protected]>wrote: > That's great, Bryan! I'm really happy to see another platform get parity > with iOS and Android. > > Looking through the PR, I'm trying to figure out what happened to > resolveLocalFileSystemURL -- it looks like it was simply removed in this > version, with the deprecated relsolveLocalFileSystemURI put back in it's > place. Was that intended? > > > > On Mon, May 5, 2014 at 9:13 AM, Bryan Higgins <[email protected] > >wrote: > > > I finally found some time to work on the promised update to the BB10 file > > plugin. It now supports the same file system roots structure as Android > and > > iOS. > > > > This is a complete re-write which uses the exec proxy rather than > > clobbering the window objects. It's still using the webkit FileSystem API > > under the hood, but has a few advantages over the previous > implementation: > > > > 1. Ability to set HTML element src from FileEntry.toURL() regardless of > > file system > > 2. Ability to copy files between file systems (ie persistent to root for > > example) > > 3. resolveLocalFileSystemURI supports all file system types (persistent, > > temporary, root, local) > > > > All mobile-spec tests are passing, but I had to make one subtle change > [1] > > to the tests. spec 89 and 90 were failing in sequence but not on their > own. > > spec 88 writes a few extra bytes to the end of a file which is written to > > again in the next tests. Those bytes show up (I think correctly) in the > > tests which slice past the end of the file. > > > > I have a pull request for this up on GitHub [2]. I will leave it up for a > > few days to give people a chance to review it. In the meantime, I will > test > > this with the rest of the plugins and see if I can dig up more info on > the > > FileReader problem. > > > > Thanks, > > Bryan > > > > [1] > > > > > https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;a=blobdiff;f=autotest/tests/file.tests.js;h=e9d57885796bddeb5fe8a14e217a4cc9a81b5c51;hp=13ab2355494849419347c91226e3fdcdb2b57821;hb=49ecd9d00484a4a437524ff2cb6fd2e87a869013;hpb=5347f9f1e09224710c98c6bd9c3c143c833d018c > > > > [2] https://github.com/apache/cordova-plugin-file/pull/44 > > >
