The original patch for ffos looks half baked anyways. It is good that it was not merged. Please reopen and merge my new PR. Axel On May 12, 2014 9:42 PM, "Sergey Grebnov (Akvelon)" <v-seg...@microsoft.com> wrote:
> Hi Axel, > > > > I think we should re-open CB-2606 since the issue and the fix both claim > FF support. It seems FF related code just was not merged. I can see it in > the pull request, but it is not in cordova-lib. > > > https://github.com/apache/cordova-cli/pull/166/files#diff-662d35f1b9303044be825d99c627ca6aR66 > > > > Thx! > > Sergey > > *From:* Axel Nennker [mailto:ignisvul...@gmail.com] > *Sent:* Monday, May 12, 2014 11:59 AM > *To:* Sergey Grebnov (Akvelon); dev > *Subject:* icon support & FFOS > https://github.com/apache/cordova-lib/pull/4 > > > > Hi Sergey, > > somehow I thought that FirefoxOS was supported in the CB-2606 patches but > it is not in cordova@rc. > > I created a PR to cordova-lib. > https://github.com/apache/cordova-lib/pull/4 > > CB-2606 is closed. Should it be reopened or a new issue opened? > > > > I am writing to you because two emails to dev did not appear on the list. > > -Axel >
