Merged, and Windows8 has been re-tagged 3.5.0 ________________________________________ From: Sergey Grebnov (Akvelon) <v-seg...@microsoft.com> Sent: May-13-14 3:40 PM To: dev@cordova.apache.org Cc: Joel Kucera; Jesse MacFadyen Subject: RE: 3.5.0 RC is ready to be tested
Hi, could someone review Windows-related fixes? CB-6685 [3.5.0rc][WP8] Build error: Command failed with exit code 2 https://github.com/apache/cordova-wp8/pull/33 CB-6684 [3.5.0rc][Windows8] Splash screen setting breaks the build https://github.com/apache/cordova-windows/pull/30 CB-6686 [3.5.0rc][Windows8] Build error if path contains whitespaces https://github.com/apache/cordova-windows/pull/31 Thx! Sergey -----Original Message----- From: Sergey Grebnov (Akvelon) Sent: Tuesday, May 13, 2014 12:43 PM To: dev@cordova.apache.org Cc: Joel Kucera Subject: RE: 3.5.0 RC is ready to be tested Added to Jira, investigating... https://issues.apache.org/jira/browse/CB-6684 https://issues.apache.org/jira/browse/CB-6685 Thx! Sergey -----Original Message----- From: Joel Kucera Sent: Tuesday, May 13, 2014 12:29 PM To: dev@cordova.apache.org Cc: Sergey Grebnov (Akvelon) Subject: RE: 3.5.0 RC is ready to be tested Hello, we found some issues with the WP8 and Windows8 platforms with 3.5.0RC today. There was a change in build.js for the WP8 platform where exec_verbose can return undefined and cause the build to fail. And on Windows8 there is some new splashscreen support that isn't working when <preference name="SplashScreen" value="screen" /> is in config.xml Sergey is investigating further and actively look into fixes for these issues. We wanted to raise awareness of these issues and we'd really like to get the fixes pulled and have the RC retagged when fixes are available. Sergey and I can provide more details if needed and keep people up to date. Thank you, Joel Kucera (I don't know if it's customary to do introductions here, but I'm an SDET at Microsoft on the team that's been working on the Cordova support in Visual Studio, so, Hi everyone, it's great to be able to be part of the community.). -----Original Message----- From: Rodrigo Silveira [mailto:rsilve...@mozilla.com] Sent: Tuesday, May 13, 2014 12:50 PM To: dev@cordova.apache.org Subject: Re: 3.5.0 RC is ready to be tested The fix for issue 2) is here: https://github.com/apache/cordova-firefoxos/pull/8 Running cordova build/compile with platform firefoxos will produce an error, this is fixed by this pull request: https://github.com/apache/cordova-firefoxos/pull/7 Can these please be pulled and tagged? Let me know if you need me to squash and rebase the last pull. Thanks, Rodrigo. ----- Original Message ----- From: "Rodrigo Silveira" <rsilve...@mozilla.com> To: dev@cordova.apache.org Sent: Tuesday, May 13, 2014 10:29:43 AM Subject: Re: 3.5.0 RC is ready to be tested Yes, number 2) is pretty bad, I'll submit fix for this shortly. ----- Original Message ----- From: "Axel Nennker" <ignisvul...@gmail.com> To: "dev" <dev@cordova.apache.org> Sent: Tuesday, May 13, 2014 8:34:02 AM Subject: Re: 3.5.0 RC is ready to be tested Regarding 2): prepare.js merges defaults.xml and config.xml which yields in duplicate elements name and description. This is a bug in cordova-lib, I think. Axel Am 13.05.2014 13:50 schrieb "Axel Nennker" <ignisvul...@gmail.com>: > 1) > I just installed 3.5.0-0.2.2 and the FirefoxOS icon PR is not in it. > Although it is in here: > > https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cord > ova/metadata/firefoxos_parser.js > > 2) > Again on platform==firefoxos the values of config.name and > config.description in firefoxos_parser.js seem to be the values of the > template app and not the values from config.xml I get this values in > manifest.webapp > "name": "HelloCordova", > "description": "A sample Apache Cordova application that responds > to the deviceready event.", while www/config.xml contains different > values. > In android's create.js the projectname is written to the > AndroidManifest.xml while on firefoxos the create.js never touches > manifest.webapp and leaves the manifest creation to > firefoxos_parser.js which seems to contain the bogus values from > ConfigParser.js. > > > > 2014-05-13 1:22 GMT+02:00 Steven Gill <stevengil...@gmail.com>: > >> New zips uploaded at >> https://dist.apache.org/repos/dist/dev/cordova/CB-6586/rc/ >> >> Update versions of CLI + plugman available at the rc tag. Uses >> updated cordova-lib. >> npm install -g cordova@rc >> npm install -g plugman@rc >> >> TEST TEST TEST! >> I will start the vote threads tomorrow as long as we don't have any >> big new issues arise. >> >> -Steve >> >> >> On Mon, May 12, 2014 at 12:16 PM, Steven Gill <stevengil...@gmail.com >> >wrote: >> >> > Cordova-blackberry got retagged. >> > >> > Cordova-lib has a few changes incoming (bb check req, ffos icon >> > support, amazon-fireos error). I will add these in, bump version >> > for lib, cli and plugman around 2pm pst. I'll also take a look at >> > any other PR on cordova-lib. >> > >> > If you have other mandatory fixes with this new setup, please >> > respond to this thread asap. >> > >> > Keep testing! Cordova-lib is a pretty big change. >> > >> > >> > On Sun, May 11, 2014 at 8:20 PM, Steven Gill >> ><stevengil...@gmail.com >> >wrote: >> > >> >> Also https://dist.apache.org/repos/dist/dev/cordova/CB-6586/ >> >> >> >> >> >> On Fri, May 9, 2014 at 4:38 PM, Steven Gill >> >> <stevengil...@gmail.com >> >wrote: >> >> >> >>> https://twitter.com/apachecordova/status/464911591561887745 >> >>> >> >>> npm install -g cordova@rc >> >>> npm install -g plugman@rc >> >>> >> >>> This release is using cordova-lib. >> >>> >> >> >> >> >> > >> > >
