Hey Rodrigo, Just looking at the pull requests. I will kill the 3.5.0 firefox OS vote, merge these in, retag 3.5.0 for FFOS and create a new vote thread for it.
Other vote threads will stay open and continue since these PRs don't affect them. On Wed, May 14, 2014 at 9:01 PM, Rodrigo Silveira <rsilve...@mozilla.com>wrote: > Hi again, > > Sorry if this is last minute but I found some issues while testing the new > build script for Firefox OS. > > 1) It unnecessarily required that manifest and index.html be in a specific > path in merges folder. > 2) It didn't work on windows. > > The fix for 1) is here: https://github.com/apache/cordova-firefoxos/pull/9 > and for 2) is: https://github.com/apache/cordova-firefoxos/pull/6 > > Can those be pulled included in 3.5? > > Thanks, > Rodrigo. > > ----- Original Message ----- > From: "Rodrigo Silveira" <rsilve...@mozilla.com> > To: dev@cordova.apache.org > Sent: Wednesday, May 14, 2014 7:37:36 PM > Subject: Re: 3.5.0 RC is ready to be tested > > The values in defaults.xml were already present in the initial config.xml, > no need to duplicate. > > ----- Original Message ----- > From: "Axel Nennker" <ignisvul...@gmail.com> > To: "dev" <dev@cordova.apache.org> > Sent: Tuesday, May 13, 2014 12:58:44 PM > Subject: Re: 3.5.0 RC is ready to be tested > > Not sure whether removing those values from defaults.xml is the _right_ > fix. > Maybe name and description should be added to the singleton list in > prepare.js and config.xml values should clobber default.xml values not vice > versa. > Am 13.05.2014 20:50 schrieb "Rodrigo Silveira" <rsilve...@mozilla.com>: > > > The fix for issue 2) is here: > > https://github.com/apache/cordova-firefoxos/pull/8 > > > > Running cordova build/compile with platform firefoxos will produce an > > error, this is fixed by this pull request: > > https://github.com/apache/cordova-firefoxos/pull/7 > > > > Can these please be pulled and tagged? Let me know if you need me to > > squash and rebase the last pull. > > > > Thanks, > > Rodrigo. > > > > ----- Original Message ----- > > From: "Rodrigo Silveira" <rsilve...@mozilla.com> > > To: dev@cordova.apache.org > > Sent: Tuesday, May 13, 2014 10:29:43 AM > > Subject: Re: 3.5.0 RC is ready to be tested > > > > Yes, number 2) is pretty bad, I'll submit fix for this shortly. > > > > ----- Original Message ----- > > From: "Axel Nennker" <ignisvul...@gmail.com> > > To: "dev" <dev@cordova.apache.org> > > Sent: Tuesday, May 13, 2014 8:34:02 AM > > Subject: Re: 3.5.0 RC is ready to be tested > > > > Regarding 2): > > prepare.js merges defaults.xml and config.xml which yields in duplicate > > elements name and description. > > This is a bug in cordova-lib, I think. > > > > Axel > > Am 13.05.2014 13:50 schrieb "Axel Nennker" <ignisvul...@gmail.com>: > > > > > 1) > > > I just installed 3.5.0-0.2.2 and the FirefoxOS icon PR is not in it. > > > Although it is in here: > > > > > > > > > https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/metadata/firefoxos_parser.js > > > > > > 2) > > > Again on platform==firefoxos the values of config.name and > > > config.description in firefoxos_parser.js seem to be the values of the > > > template app and not the values from config.xml > > > I get this values in manifest.webapp > > > "name": "HelloCordova", > > > "description": "A sample Apache Cordova application that responds > to > > > the deviceready event.", > > > while www/config.xml contains different values. > > > In android's create.js the projectname is written to the > > > AndroidManifest.xml while on firefoxos the create.js never touches > > > manifest.webapp and leaves the manifest creation to firefoxos_parser.js > > > which seems to contain the bogus values from ConfigParser.js. > > > > > > > > > > > > 2014-05-13 1:22 GMT+02:00 Steven Gill <stevengil...@gmail.com>: > > > > > >> New zips uploaded at > > >> https://dist.apache.org/repos/dist/dev/cordova/CB-6586/rc/ > > >> > > >> Update versions of CLI + plugman available at the rc tag. Uses updated > > >> cordova-lib. > > >> npm install -g cordova@rc > > >> npm install -g plugman@rc > > >> > > >> TEST TEST TEST! > > >> I will start the vote threads tomorrow as long as we don't have any > big > > >> new > > >> issues arise. > > >> > > >> -Steve > > >> > > >> > > >> On Mon, May 12, 2014 at 12:16 PM, Steven Gill <stevengil...@gmail.com > > >> >wrote: > > >> > > >> > Cordova-blackberry got retagged. > > >> > > > >> > Cordova-lib has a few changes incoming (bb check req, ffos icon > > support, > > >> > amazon-fireos error). I will add these in, bump version for lib, cli > > and > > >> > plugman around 2pm pst. I'll also take a look at any other PR on > > >> > cordova-lib. > > >> > > > >> > If you have other mandatory fixes with this new setup, please > respond > > to > > >> > this thread asap. > > >> > > > >> > Keep testing! Cordova-lib is a pretty big change. > > >> > > > >> > > > >> > On Sun, May 11, 2014 at 8:20 PM, Steven Gill < > stevengil...@gmail.com > > >> >wrote: > > >> > > > >> >> Also https://dist.apache.org/repos/dist/dev/cordova/CB-6586/ > > >> >> > > >> >> > > >> >> On Fri, May 9, 2014 at 4:38 PM, Steven Gill < > stevengil...@gmail.com > > >> >wrote: > > >> >> > > >> >>> https://twitter.com/apachecordova/status/464911591561887745 > > >> >>> > > >> >>> npm install -g cordova@rc > > >> >>> npm install -g plugman@rc > > >> >>> > > >> >>> This release is using cordova-lib. > > >> >>> > > >> >> > > >> >> > > >> > > > >> > > > > > > > > >
