Github user kamrik commented on the pull request:
https://github.com/apache/cordova-lib/pull/20#issuecomment-44544621
Looks good. One nit: please use 4 space tabs in cordova-lib.js, for
consistency with most of the other js files in the project.
On a general note, this goes part of the way to making "cordova" be not a
module but an instance of a class.
say
cordova = new CordovaProject(project_root_dir, config)
then accessing things like this.binname would feel more like the usual OOP
style and not as awkward as setting it in the util module, which is pretty
arbitrary (though I totally understand why you chose to keep binname in
utils.js).
This is not yet fully baked in my mind, so I would like to bounce the idea
around.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
