I guess I'd have +1 the inappbrowser, although no idea if that counts
as I'm the author of most fixes for ffo in this plugin
Dnia Mon Jun 9 15:03:45 2014 Ian Clelland pisze:
The code which is being voted on, though, isn't represented by that commit.
There are significant differences. (They appear to be all confined to
Firefox OS)
The way to reproduce the original tagged commit is to cherry-pick commit
992306b ("CB-6877 Updated version and RELEASENOTES.md for release 0.5.0")
onto commit 393524a ("CB-6127 Spanish and rench Translations added. Github
close #23")
Steve, can you push your commit e6e911c to the ASF repo, under some named
branch?
On Mon, Jun 9, 2014 at 7:16 AM, Martin Bektchiev <
martin.bektch...@telerik.com> wrote:
It seems that the tag points to a commit which is not present in any of
the branches. I guess that the correct commit which should be tagged is:
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;a=commit;h=992306bbc58f3ba9dc0f4dbcde1b084db5ba8169
-----Original Message-----
From: Steven Gill [mailto:stevengil...@gmail.com]
Sent: Saturday, June 7, 2014 12:05 AM
To: dev@cordova.apache.org
Subject: Re: [VOTE] Plugins Release
Marcel: Yes.
Andrew: I see it
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git
On Fri, Jun 6, 2014 at 9:02 AM, Andrew Grieve <agri...@chromium.org>
wrote:
I don't see the tag for inappbrowser. Forgot to push it?
On Fri, Jun 6, 2014 at 10:46 AM, Marcel Kinard <cmarc...@gmail.com>
wrote:
Steve, to clarify, a single vote is for all the plugins listed below,
correct?
On Jun 5, 2014, at 5:44 PM, Steven Gill <stevengil...@gmail.com>
wrote:
Please review and vote on the release of this plugins release.
Release issue: https://issues.apache.org/jira/browse/CB-6877
The plugins have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-6877/
The packages were published from their corresponding git tags:
cordova-plugin-camera: 0.3.0 (4fa934e06f)
cordova-plugin-console: 0.2.9 (f3764d8318)
cordova-plugin-device: 0.2.10 (159d55eb1d)
cordova-plugin-device-motion: 0.2.8 (51d58d6d29)
cordova-plugin-device-orientation: 0.3.7 (d66777a007)
cordova-plugin-dialogs: 0.2.8 (057d6cc4e9)
cordova-plugin-file: 1.2.0 (e02d3d0f8e)
cordova-plugin-file-transfer: 0.4.4 (db9eca0aa8)
cordova-plugin-geolocation: 0.3.8 (a403b4abb6)
cordova-plugin-globalization: 0.2.8 (9a4e8c81e5)
cordova-plugin-inappbrowser: 0.5.0 (e6e911c941)
cordova-plugin-media: 0.2.11 (ee68987d3b)
cordova-plugin-media-capture: 0.3.1 (70cd9a0ee3)
cordova-plugin-network-information: 0.2.9 (be5875f9d9)
cordova-plugin-splashscreen: 0.3.1 (b3b7a561ab)
cordova-plugin-statusbar: 0.1.6 (11195658af)
cordova-plugin-vibration: 0.3.9 (b2fdbc1c92)
I am getting failing tests for contacts + battery. I have decided not
to release them until they get reviewed.
Upon a successful vote I will upload the archives to dist/, upload
them to the Plugins Registry, and post the corresponding blog post.
Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
Voting will go on for a minimum of 72 hours.
I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ensured tests were passing on iOS & Android by using
createmobilespec
script
--
Piotr Zalewa
Mozilla
