Github user javierbb31 commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/34#discussion_r13984170
  
    --- Diff: plugin.xml ---
    @@ -33,6 +33,9 @@
         <js-module src="www/CameraConstants.js" name="Camera">
             <clobbers target="Camera" />
         </js-module>
    +   
    +   <js-module src="test/tests.js" name="tests">
    --- End diff --
    
    Yes, it means that the tests are going to be added on every project that 
uses this plugin, however, this PR it should have to be addressed to another 
branch(cdvtest, as it is for the plugin-device, which already has the tests for 
the plugin-test framework.
    https://github.com/apache/cordova-plugin-device/tree/cdvtest
    Are you able to create the branch cdvtest for this repository?
    Is there any way to correctly address this PR to that branch once created?
    
    Thanks for the feedback.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to