the version scripts are just about the only thing about the platform scripts that are simple enough to rewrite trivially. Leveraging a rewrite/refactor of the version script into a total rewrite of platform level scripts == 'lulz'
On Tue, Aug 12, 2014 at 1:15 PM, Jesse <purplecabb...@gmail.com> wrote: > the non-cordova cli path depends on node to install/uninstall plugins > > @purplecabbage > risingj.com > > > On Tue, Aug 12, 2014 at 1:08 PM, Shazron <shaz...@gmail.com> wrote: > > > Of course I considered nodejs, but no, this is for the non-cordova CLI > > path, which does not need another dependency. > > > > On Tue, Aug 12, 2014 at 11:52 AM, Jesse <purplecabb...@gmail.com> wrote: > > > Yeah, if you are going to replace bash, replace it with nodejs! > > > > > > > > > @purplecabbage > > > risingj.com > > > > > > > > > On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <my...@famo.us> wrote: > > > > > >> Have you considered writing a small node script to pass the json? This > > >> would make it as simple as requiring in the package json an piping the > > >> relevant info to stdout > > >> On Aug 12, 2014 11:47 AM, "Shazron" <shaz...@gmail.com> wrote: > > >> > > >> > Yeah I value life and my sanity - I'll probably replace the bash > > >> > script with python > > >> > > > >> > On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <lorin.b...@gmail.com> > > >> wrote: > > >> > > one source for version information is better > > >> > > > > >> > > although parsing json with bash scripts seems janky > > >> > > > > >> > > > > >> > > On Tue, Aug 12, 2014 at 11:31 AM, Jesse <purplecabb...@gmail.com> > > >> wrote: > > >> > > > > >> > >> I think it still needs to exist in an output project ... which is > > not > > >> > >> (yet?) an npm project, and so does not have a package.json. > > >> > >> > > >> > >> The individual platform repos can get rid of it, they will just > > need > > >> to > > >> > >> modify the way they `create` new projects to read the value from > > >> > >> package.json and output it to NewProject/VERSION > > >> > >> > > >> > >> > > >> > >> > > >> > >> > > >> > >> @purplecabbage > > >> > >> risingj.com > > >> > >> > > >> > >> > > >> > >> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <shaz...@gmail.com> > > wrote: > > >> > >> > > >> > >> > For iOS, the only file I can see that depends on this is: > > >> > >> > > > >> > >> > 1. > > >> > >> > > > >> > >> > > >> > > > >> > > > https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version > > >> > >> > > > >> > >> > Not sure of the alternative. > > >> > >> > > > >> > >> > This references it but can be removed: > > >> > >> > https://github.com/apache/cordova-ios/blob/master/bin/create > > >> > >> > > > >> > >> > > > >> > >> > On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill < > > >> stevengil...@gmail.com > > >> > > > > >> > >> > wrote: > > >> > >> > > Most of our repos have a package.json. It keeps track of > > >> versions. I > > >> > >> > think > > >> > >> > > we should work towards removing the VERSION files from the > > repos > > >> we > > >> > >> can. > > >> > >> > > > > >> > >> > > Thoughts? > > >> > >> > > > > >> > >> > > This would require some changes to coho so it doesn't try to > > >> update > > >> > the > > >> > >> > > version file when doing releases. > > >> > >> > > > >> > >> > > >> > > > >> > > >
