+1 to fixing the test
-1 to warnings

warnings are either treated like errors, or ignored entirely. I'm for
treating warnings like errors in the first place


On Thu, Aug 21, 2014 at 1:53 PM, Marcel Kinard <cmarc...@gmail.com> wrote:

> I agree. My personal philosophy is generally to treat warnings as errors.
>
> On Aug 21, 2014, at 9:27 AM, Mark Koudritsky <kam...@google.com> wrote:
>
> > If some tests are too strict or too flaky, we can and should fix or
> remove
> > them altogether. I don't believe there is any value in warnings, they
> will
> > accumulate and then people will largely ignore them.
>
>

Reply via email to