Resolved for iOS. sent PR for cordova-coho
On Fri, Aug 29, 2014 at 11:51 AM, Steven Gill <stevengil...@gmail.com> wrote: > I created one now. https://issues.apache.org/jira/browse/CB-7432 > > > > > On Thu, Aug 28, 2014 at 10:17 PM, Gorkem Ercan <gorkem.er...@gmail.com> > wrote: > >> Is there a JIRA to follow up on this change? >> -- >> Gorkem >> >> >> On Fri, Aug 29, 2014 at 3:16 AM, Steven Gill <stevengil...@gmail.com> >> wrote: >> >> > Just a quick update to this. >> > >> > Coho now updates the version script for the following platforms: >> > Android >> > Amazon-fireos >> > Ubuntu >> > Firefoxos >> > Blackberry >> > >> > If coho is being used for releases, I think this is the way to go. iOS, >> > windows and wp8 are the only remaining ones. >> > >> > Line to edit in coho: >> > >> > >> https://github.com/apache/cordova-coho/blob/master/src/cadance-release.js#L124 >> > Sample version script: >> > >> > >> https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/version >> > >> > Let me know if you are going to make this change for your platforms. I >> will >> > need to copy it over to my platform-release file which will replace >> cadence >> > release after 3.6.0: >> > >> > >> https://github.com/stevengill/cordova-coho/blob/cb-7224/src/platform-release.js#L124 >> > >> > >> > >> > >> > On Thu, Aug 14, 2014 at 10:15 AM, purplecabbage <purplecabb...@gmail.com >> > >> > wrote: >> > >> > > >> > > >> > > > On Aug 14, 2014, at 4:09 AM, Ian Clelland <iclell...@chromium.org> >> > > wrote: >> > > > >> > > > +1 -- there's little value in trying to derive something at runtime >> > that >> > > > should just be hard-coded. (And even if we didn't have coho, we could >> > set >> > > > it manually without too much effort. :) ) >> > > >> > > If we remember to. >> > > +0 >> > > >> > > >> > > > >> > > > >> > > >> On Wed, Aug 13, 2014 at 8:28 PM, Steven Gill < >> stevengil...@gmail.com> >> > > wrote: >> > > >> >> > > >> Using android's method of doing this doesn't seem so bad to me. >> > > >> >> > > >> Version script has hard coded value that coho sets when doing a >> > release. >> > > >> Seems to be working fine as long as coho is used for releasing. >> > > >> >> > > >> Thoughts? >> > > >> >> > > >> >> > > >> On Wed, Aug 13, 2014 at 1:44 PM, Carlos Santana < >> csantan...@gmail.com >> > > >> > > >> wrote: >> > > >> >> > > >>> I think having the ios platform scripts in nodejs have a side >> benefit >> > > of >> > > >>> being able to create ios platform on Linux and Windows. >> > > >>> >> > > >>> IBM Worklight customers use this use case, where they create ios >> > > cordova >> > > >>> app, and in Windows or Linux they use it for preview with MBS a >> tool >> > > >>> similar to Ripple, and generate a zip with the xcode project, they >> > can >> > > >> use >> > > >>> on a Mac with XCode for final build. >> > > >>> >> > > >>> The use case is also similar to create an ios platform app and >> > preview >> > > in >> > > >>> App Harness like PhoneGap Developer. >> > > >>> >> > > >>> just my two cents. >> > > >>> >> > > >>> >> > > >>> >> > > >>>> On Tue, Aug 12, 2014 at 4:46 PM, Shazron <shaz...@gmail.com> >> wrote: >> > > >>>> >> > > >>>> Believe me, I want to go all node -- but all in for all scripts -- >> > > >>>> which we don't have time to do yet (maybe 4.0?). >> > > >>>> But seeing that it's just replacing the contents of the current >> bash >> > > >>>> script with python code, it's the path of least resistance, and >> path >> > > >>>> of least potential conflict imo. No one will notice. >> > > >>>> >> > > >>>> >> > > >>>> On Tue, Aug 12, 2014 at 1:36 PM, Michal Mocny < >> mmo...@chromium.org> >> > > >>> wrote: >> > > >>>>> Shaz, that's technically true, but how many users actually use >> that >> > > >>> path >> > > >>>>> these days? >> > > >>>>> >> > > >>>>> I thought the last stats overwhelmingly suggest our users are >> > > >> drinking >> > > >>>> the >> > > >>>>> kool-aid and using cli, node, etc. >> > > >>>>> >> > > >>>>> >> > > >>>>>> On Tue, Aug 12, 2014 at 4:19 PM, Shazron <shaz...@gmail.com> >> > wrote: >> > > >>>>>> >> > > >>>>>> Not if they are installed manually. It's not worth having some >> > > >>>>>> dependency just to read a version, that's nuts. >> > > >>>>>> >> > > >>>>>> On Tue, Aug 12, 2014 at 1:15 PM, Jesse <purplecabb...@gmail.com >> > >> > > >>> wrote: >> > > >>>>>>> the non-cordova cli path depends on node to install/uninstall >> > > >>> plugins >> > > >>>>>>> >> > > >>>>>>> @purplecabbage >> > > >>>>>>> risingj.com >> > > >>>>>>> >> > > >>>>>>> >> > > >>>>>>> On Tue, Aug 12, 2014 at 1:08 PM, Shazron <shaz...@gmail.com> >> > > >> wrote: >> > > >>>>>>> >> > > >>>>>>>> Of course I considered nodejs, but no, this is for the >> > > >> non-cordova >> > > >>>> CLI >> > > >>>>>>>> path, which does not need another dependency. >> > > >>>>>>>> >> > > >>>>>>>> On Tue, Aug 12, 2014 at 11:52 AM, Jesse < >> > purplecabb...@gmail.com >> > > >>> >> > > >>>>>> wrote: >> > > >>>>>>>>> Yeah, if you are going to replace bash, replace it with >> nodejs! >> > > >>>>>>>>> >> > > >>>>>>>>> >> > > >>>>>>>>> @purplecabbage >> > > >>>>>>>>> risingj.com >> > > >>>>>>>>> >> > > >>>>>>>>> >> > > >>>>>>>>> On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins < >> my...@famo.us> >> > > >>>> wrote: >> > > >>>>>>>>> >> > > >>>>>>>>>> Have you considered writing a small node script to pass the >> > > >>> json? >> > > >>>>>> This >> > > >>>>>>>>>> would make it as simple as requiring in the package json an >> > > >>> piping >> > > >>>>>> the >> > > >>>>>>>>>> relevant info to stdout >> > > >>>>>>>>>> On Aug 12, 2014 11:47 AM, "Shazron" <shaz...@gmail.com> >> > > >> wrote: >> > > >>>>>>>>>> >> > > >>>>>>>>>>> Yeah I value life and my sanity - I'll probably replace the >> > > >>> bash >> > > >>>>>>>>>>> script with python >> > > >>>>>>>>>>> >> > > >>>>>>>>>>> On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer < >> > > >>>> lorin.b...@gmail.com >> > > >>>>>>> >> > > >>>>>>>>>> wrote: >> > > >>>>>>>>>>>> one source for version information is better >> > > >>>>>>>>>>>> >> > > >>>>>>>>>>>> although parsing json with bash scripts seems janky >> > > >>>>>>>>>>>> >> > > >>>>>>>>>>>> >> > > >>>>>>>>>>>> On Tue, Aug 12, 2014 at 11:31 AM, Jesse < >> > > >>>> purplecabb...@gmail.com >> > > >>>>>>> >> > > >>>>>>>>>> wrote: >> > > >>>>>>>>>>>> >> > > >>>>>>>>>>>>> I think it still needs to exist in an output project ... >> > > >>>> which >> > > >>>>>> is >> > > >>>>>>>> not >> > > >>>>>>>>>>>>> (yet?) an npm project, and so does not have a >> > > >> package.json. >> > > >>>>>>>>>>>>> >> > > >>>>>>>>>>>>> The individual platform repos can get rid of it, they >> > > >> will >> > > >>>> just >> > > >>>>>>>> need >> > > >>>>>>>>>> to >> > > >>>>>>>>>>>>> modify the way they `create` new projects to read the >> > > >> value >> > > >>>> from >> > > >>>>>>>>>>>>> package.json and output it to NewProject/VERSION >> > > >>>>>>>>>>>>> >> > > >>>>>>>>>>>>> >> > > >>>>>>>>>>>>> >> > > >>>>>>>>>>>>> >> > > >>>>>>>>>>>>> @purplecabbage >> > > >>>>>>>>>>>>> risingj.com >> > > >>>>>>>>>>>>> >> > > >>>>>>>>>>>>> >> > > >>>>>>>>>>>>> On Tue, Aug 12, 2014 at 11:25 AM, Shazron < >> > > >>> shaz...@gmail.com >> > > >>>>> >> > > >>>>>>>> wrote: >> > > >>>>>>>>>>>>> >> > > >>>>>>>>>>>>>> For iOS, the only file I can see that depends on this >> > > >> is: >> > > >>>>>>>>>>>>>> >> > > >>>>>>>>>>>>>> 1. >> > > >> >> > > >> > >> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version >> > > >>>>>>>>>>>>>> >> > > >>>>>>>>>>>>>> Not sure of the alternative. >> > > >>>>>>>>>>>>>> >> > > >>>>>>>>>>>>>> This references it but can be removed: >> > > >>>> https://github.com/apache/cordova-ios/blob/master/bin/create >> > > >>>>>>>>>>>>>> >> > > >>>>>>>>>>>>>> >> > > >>>>>>>>>>>>>> On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill < >> > > >>>>>>>>>> stevengil...@gmail.com >> > > >>>>>>>>>>>> >> > > >>>>>>>>>>>>>> wrote: >> > > >>>>>>>>>>>>>>> Most of our repos have a package.json. It keeps track >> > > >>> of >> > > >>>>>>>>>> versions. I >> > > >>>>>>>>>>>>>> think >> > > >>>>>>>>>>>>>>> we should work towards removing the VERSION files >> > > >> from >> > > >>>> the >> > > >>>>>>>> repos >> > > >>>>>>>>>> we >> > > >>>>>>>>>>>>> can. >> > > >>>>>>>>>>>>>>> >> > > >>>>>>>>>>>>>>> Thoughts? >> > > >>>>>>>>>>>>>>> >> > > >>>>>>>>>>>>>>> This would require some changes to coho so it doesn't >> > > >>>> try to >> > > >>>>>>>>>> update >> > > >>>>>>>>>>> the >> > > >>>>>>>>>>>>>>> version file when doing releases. >> > > >>> >> > > >>> >> > > >>> >> > > >>> -- >> > > >>> Carlos Santana >> > > >>> <csantan...@gmail.com> >> > > >> >> > > >> > >>
