Sorry about the bad commit message. Was a part of my not-so-good-at-explaining streak :S.
The rationale I had was that with the code in init(), there was no way to programmatically influence the behaviour of the preferences that you had. I tried to make the split now so that preferences are loaded in onCreate(), and then not acted upon until init(), so this way you can set preferences programmatically between the two if you'd like. Which part of the change is causing a break for you? Is it that createViews() isn't called during onCreate? If so - does adding an explicit call to init() from within your subclass work around the problem? On Mon, Sep 29, 2014 at 5:26 PM, Marcel Kinard <[email protected]> wrote: > The reason why Martin and I are asking about this is because it is causing > a breaking change to our product. Unless there is reason, we'd like to move > that part from init() back to onCreate(). > > It looks like there is a matching change in > bin/template/project/Activity.java, so this may be breaking for other > Cordova users besides our project, even if it is just a one-liner. > > This would be a good candidate for 3.6.4 of cordova-android. > > On Sep 29, 2014, at 2:27 PM, Joe Bowser <[email protected]> wrote: > > > That's a very good question, why was this removed Andrew? > > > > On Mon, Sep 29, 2014 at 11:08 AM, Martin Gonzalez < > > [email protected]> wrote: > > > >> Hi devs, > >> > >> I'm getting some problems performing async tasks (android.os.AsyncTask) > >> over android 3.6.x master, using native code before performing > loadUrl(). > >> I've found out that onCreate it doesn't setup config and preferences > >> anymore, that code it was moved to init() method. > >> > >> I'm just wondering, why this code was moved to init(), and removed from > >> onCreate()? > >> This is the commit and its subject, but there's no JIRA item related. > >> > >> Un-deprecate CordovaActivity.init() - it's needed to tweak prefs in > >> onCreate, by Andrew Grieve > >> > >> > https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commit;h=a14c7942557fbaea41438bd3fe104b47997d8371 > >> > >> Thanks. > >> -- > >> Regards, > >> Martin Gonzalez > >> > >
