Github user sgrebnov commented on the pull request:

    https://github.com/apache/cordova-plugin-file/pull/54#issuecomment-58239667
  
    Reviewed, lgtm except some inline note and failed test 'file.spec.106 
should be able to write a File to a FileWriter' . This is because 'File' is 
cordova specific implementation so does not have msDetachStream method in 
comparion to native Blob.
    
    I'll merge this version tomorrow and do one more iteration improving 
FileProxy since I see many tests failed. Thank you, @SomaticIT  for this patch!



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to