I'm sorry that I missed this, and that it never got the review that it deserved -- thanks for at least taking the right step and giving the whole dev community the chance to review it first, though.
According to a bug report this morning ( https://issues.apache.org/jira/browse/CB-7868), it looks like this code breaks on Android, from versions 2.3 to 4.0.3. I haven't verified it, but it looks likely. (Not sure whether 4.0.4 would be affected as well) If I get a chance this afternoon, I'll see if I can come up with a cross-platform solution for it. Otherwise, if anyone sees an obvious fix before I get to it, feel free to jump in (Joe? Andrew?) Ian On Wed, Sep 10, 2014 at 12:09 PM, Shazron <shaz...@gmail.com> wrote: > PR: https://github.com/apache/cordova-js/pull/80 > Issue: https://issues.apache.org/jira/browse/CB-6911 > > May I humbly request a review of the pull request above. Since it affects > all platforms, I thought it would be prudent. > > Note the deprecation "error" is just a warning (not sure why Safari Web > Inspector shows it with an error icon) since it doesn't really affect the > app (no exception), but it's better to fix it now rather than later. > > replaceNavigator proxies window.navigator functions so that cordova can > override/clobber window.navigator functions, this patch enables it to proxy > properties as well, removing the error message. >
