Github user clelland commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/116#discussion_r19623071
--- Diff: CordovaLib/Classes/CDVViewController.m ---
@@ -714,24 +712,44 @@ - (BOOL)webView:(UIWebView*)theWebView
shouldStartLoadWithRequest:(NSURLRequest*
}
/*
- * If a URL is being loaded that's a file/http/https URL, just load it
internally
+ * If we loaded the HTML from a string, we let the app handle it
*/
- if ([url isFileURL]) {
+ if (self.loadFromString == YES) {
+ self.loadFromString = NO;
return YES;
}
/*
- * If we loaded the HTML from a string, we let the app handle it
+ * Handle all other types of urls (tel:, sms:), and requests to load a
url in the main webview.
*/
- else if (self.loadFromString == YES) {
--- End diff --
Also, this was the original source of the "== YES"; git diff just makes it
*look* like I added that ;)
I'll pull the other instances out of the file while I'm here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
