Those instructions look good to me -Steve
On Mon, Nov 10, 2014 at 3:54 PM, Mark Koudritsky <kam...@google.com> wrote: > Ok, published new packages and a new vote thread. > > Thinking about fixes the the release doc [1]. > > We need some clear instructions for the case when releasing with an update > from an existing branch. Does the following sound right? > Assuming a micro version bump is needed from 4.1.0 to 4.1.1. > > * On master, changed 4.1.1-dev in package.json to 4.1.2-dev, commit and > push > * On 4.1.x branch > - merge any required fixes > - change 4.1.0 to 4.1.1 > - change versions in package.json dependencies appropriately > - commit > - git tag 4.1.1 > - git push && git push --tags (assumes upstream is set properly) > > > > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md > > On Mon, Nov 10, 2014 at 5:22 PM, Steven Gill <stevengil...@gmail.com> > wrote: > > > In terms of having to bump the version when you have to retag an rc that > > has been published to npm: > > > > The reason why this is necessary is because we want to test exactly what > we > > vote on. We push the tgz file that we are voting on to npm under the rc > > flag. The alternative would be to extract it, change the version in > > package.json to include `-rc1` to it and then publish (or do this step > > before building the archive). We would then have to make sure the > > dependency is correctly set for repos that rely on lib (cli would have to > > change cordova-lib dependency to include -rc1 to the version for it). > > > > This opens us up to errors in the release process and is not worth it. > > Re-tagging shouldn't happen often. When it does, it should be fairly > quick > > as long as we are using release branches (which we are doing according to > > release doc). > > > > On Mon, Nov 10, 2014 at 2:16 PM, Mark Koudritsky <kam...@google.com> > > wrote: > > > > > This vote is cancelled. > > > > > > Blocking issue https://issues.apache.org/jira/browse/CB-8000 > > > Will post a new vote with updated packages > > > > > > On Mon, Nov 10, 2014 at 12:34 PM, Sergey Grebnov (Akvelon) < > > > v-seg...@microsoft.com> wrote: > > > > > > > Thank you Mark; Resending link to the fix here since looks like I > > > answered > > > > not to the latest email last time. > > > > https://github.com/apache/cordova-lib/pull/118/ > > > > > > > > Thx! > > > > Sergey > > > > -----Original Message----- > > > > From: Mark Koudritsky [mailto:kam...@google.com] > > > > Sent: Monday, November 10, 2014 9:14 AM > > > > To: dev@cordova.apache.org > > > > Subject: Re: [VOTE] Tools Release > > > > > > > > Yep, the hash as a versions seems like something that should break > the > > > npm > > > > download as well. > > > > Sergey, I'll merge your patch and republish rc packages. > > > > Maria, thanks for finding this. > > > > > > > > Note, the lib will have a different version number 4.1.1 because npm > > > > forbids uploading anything with the same version string more than > once > > > [1]. > > > > We should come up with some procedure of promoting RCs that would not > > > > necessitate bumping the version. > > > > > > > > One option is to download the package with x.y.z-rcN from npm, and > > have a > > > > script that unpacks it, strips the -rcN and repacks the same files > > back. > > > > (not sure how to deal with signing in this case). > > > > > > > > [1] - https://github.com/npm/npm-registry-couchapp/issues/148 > > > > > > > > On Mon, Nov 10, 2014 at 12:06 PM, Sergey Grebnov (Akvelon) < > > > > v-seg...@microsoft.com> wrote: > > > > > > > > > I've found the case will submit the patch shortly - Jira +PR to > > master > > > > > > > > > > Problem cause: we've recently got rid of subdirs for wp8 and > windows > > > > > but still have them defined in tools. > > > > > > > > > > > > https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cord > > > > > ova/platformsConfig.json#L53 > > > > > > > > > > Thx! > > > > > Sergey > > > > > -----Original Message----- > > > > > From: Steven Gill [mailto:stevengil...@gmail.com] > > > > > Sent: Monday, November 10, 2014 8:57 AM > > > > > To: dev@cordova.apache.org > > > > > Subject: RE: [VOTE] Tools Release > > > > > > > > > > Definitely a problem. Thanks for testing and finding it! > > > > > > > > > > -1 > > > > > On Nov 10, 2014 8:51 AM, "Maria Bukharina" > > > > > <maria.bukhar...@akvelon.com> > > > > > wrote: > > > > > > > > > > > Hi all, > > > > > > > > > > > > I've tried to create app with this rc and discover that adding > wp8 > > > > > > and windows platforms with --usegit key fails: > > > > > > > > > > > > cordova platform add wp8 --usegit > > > > > > Creating wp8 project... > > > > > > Error:.cordova\lib\wp\cordova\4.1.0\bin\create: Command > > > > > > failed with exit code ENOENT > > > > > > at ChildProcess.whenDone > > > > > > > > > > > > > (d:\Projects\cordova\cordova4.1\cordova-lib-4.1.0\package\src\cordova\ > > > > > superspawn.js:135:23) > > > > > > at ChildProcess.EventEmitter.emit (events.js:95:17) > > > > > > at Process.ChildProcess._handle.onexit > > > > > > (child_process.js:805:12) > > > > > > > > > > > > > > > > > > Seemed that file platformConfig.json in > > > > > > .\cordova-lib\cordova-lib\src\cordova has invalid data for wp8 > and > > > > > > windows > > > > > > platforms: > > > > > > for wp8 there are wrong version and subdirectory properties: > > > > > > "wp8": { > > > > > > "hostos": ["win32"], > > > > > > "parser": "./metadata/wp8_parser", > > > > > > "url": > > > > > > "https://git-wip-us.apache.org/repos/asf?p=cordova-wp8.git > > > > > > ", > > > > > > "version": "b2b1e6185444e0dd6a6b9b19df9005cfc5bc5d80", > > > > > > "altplatform": "wp", > > > > > > "subdirectory": "3.7.0" > > > > > > }, > > > > > > > > > > > > windows for now doesn't contain subfolder "windows": > > > > > > "windows": { > > > > > > "hostos": ["win32"], > > > > > > "parser": "./metadata/windows_parser", > > > > > > "url": " > > > > > > https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git";, > > > > > > "version": "3.7.0", > > > > > > "subdirectory": "windows" > > > > > > }, > > > > > > > > > > > > What's your opinion, is it critical for release? > > > > > > > > > > > > > > > > > > Thanks, > > > > > > Maria > > > > > > > > > > > > -----Original Message----- > > > > > > From: Mark Koudritsky [mailto:kam...@google.com] > > > > > > Sent: Saturday, November 8, 2014 01:17 > > > > > > To: dev@cordova.apache.org > > > > > > Subject: [VOTE] Tools Release > > > > > > > > > > > > Please review and vote on this Tools Release. > > > > > > > > > > > > Release issue: https://issues.apache.org/jira/browse/CB-7988 > > > > > > > > > > > > Packages have been published to dist/dev: > > > > > > https://dist.apache.org/repos/dist/dev/cordova/CB-7988/ > > > > > > And to npm under @rc tag > > > > > > > > > > > > To test them out you can use: > > > > > > npm -g uninstall cordova > > > > > > npm -g install cordova@rc > > > > > > > > > > > > The packages were published from their corresponding git tags: > > > > > > > > > > > > cordova-js: 3.7.2 (7afadfc044) > > > > > > cordova-lib: 4.1.0 (0141806d73) > > > > > > cordova-plugman: 0.22.14 (cdb84dda53) > > > > > > cordova-cli: 4.1.0 (e33cfc90a0) > > > > > > > > > > > > Upon a successful vote I will upload the archives to dist/, > publish > > > > > > them to NPM (under @latest tag), and post the corresponding blog > > > post. > > > > > > > > > > > > Voting guidelines: > > > > > > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voti > > > > > > ng > > > > > > .md > > > > > > > > > > > > Voting will go on for a minimum of 48 hours. > > > > > > > > > > > > I vote +1: > > > > > > * Ran coho audit-license-headers over the relevant repos > > > > > > * tested with npm test and mobilespec on Android > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > > > > > > > > > > > > > > >
