I'd also recommend hooks for now.
<json-file> tag sounds potentially more resilient to change, but since you
have to explicitly reference the path to target I don't think its any
better in practice.
Additionally, we've expressed interest in replacing our xml based configs
with json manifests, and while that work may not be in a hurry, it seems
counterproductive to extend the scope of plugin/app configs right now.
-Michal
On Tue, Nov 11, 2014 at 2:09 PM, Axel Nennker <ignisvul...@gmail.com> wrote:
> I would not modify the value. Can config-file replace values?
> Just adding stuff would be good enough for my (current) purposes.
> I would throw on existing keys.
> When two plugins add the same key then plugman should throw and I don't
> want to track all changes over all plugins.
>
> 2014-11-11 19:58 GMT+01:00 Jesse <purplecabb...@gmail.com>:
>
> > I would like to see a new element titled 'json-file' and matching parser
> > that does the work.
> > something like this?
> >
> > <json-file target="someManifest.json" parent="some.object.path">
> > "{the:{stringValue:2,b:"added"},or:{modified:true}}"
> > </json-file>
> >
> >
> > @purplecabbage
> > risingj.com
> >
> > On Tue, Nov 11, 2014 at 9:02 AM, Shazron <shaz...@gmail.com> wrote:
> >
> > > Have you considered plugin hooks?
> > > I just implemented this yesterday to modify the root config.xml file:
> > >
> > >
> >
> https://github.com/apache/cordova-plugins/blob/master/local-webserver/plugin.xml
> > >
> > > On Tuesday, November 11, 2014, Axel Nennker <ignisvul...@gmail.com>
> > wrote:
> > >
> > > > Hi,
> > > >
> > > > if I remember correctly then this was discussed before but I can't
> find
> > > the
> > > > email exchange.
> > > >
> > > > We are trying to use our cordova app on firefoxos and would like to
> > > modify
> > > > manifest.webapp which is a json file.
> > > >
> > > > In plugin.xml we can only modify xml files using the config-file
> > element.
> > > >
> > > > What are your preference on how to implenent this?
> > > > - reuse config-file with new attribute type="json" (default "xml")
> > > > or new element e.g. "config-file-json"
> > > > - only adding to the json and throw if key already exists?
> > > > - ...
> > > >
> > > > Should I file an issue and implement it?
> > > >
> > > > cheers
> > > > Axel
> > > >
> > >
> >
>
