Ian, can you take a look into this PR before updating the dialogs plugin? https://issues.apache.org/jira/browse/CB-7734 https://github.com/apache/cordova-plugin-dialogs/pull/39
2014-11-26 10:16 GMT+01:00 Sergey Grebnov (Akvelon) <v-seg...@microsoft.com> : > Jesse, sounds good, you can re-work any of them to show example/pattern > and I'll assist you in reworking the rest. > > Thx! > Sergey > -----Original Message----- > From: Jesse [mailto:purplecabb...@gmail.com] > Sent: Tuesday, November 25, 2014 9:55 PM > To: dev@cordova.apache.org > Subject: Re: [Discuss] Plugins release > > +1 to getting the updates out. > > Sergey, I would like to hold off on those plugins until I can do a > windows-universal refactor to get rid of all the extra csproj's that are > being added. > > @purplecabbage > risingj.com > > On Tue, Nov 25, 2014 at 7:43 AM, Sergey Grebnov (Akvelon) < > v-seg...@microsoft.com> wrote: > > > +1, fully support as well. If someone has a chance to take a look on > > +the > > following PRs I will appreciate this! Thx > > > > https://github.com/apache/cordova-plugin-vibration/pull/25 > > https://github.com/apache/cordova-plugin-battery-status/pull/19 > > https://github.com/apache/cordova-plugin-globalization/pull/31 > > > > Thx! > > Sergey > > -----Original Message----- > > From: Ian Clelland [mailto:iclell...@chromium.org] > > Sent: Tuesday, November 25, 2014 4:36 PM > > To: dev@cordova.apache.org > > Subject: Re: [Discuss] Plugins release > > > > +1, I heartily support this. > > > > I'll take a look at the PRs and call out any that I think need extra > > consideration. (We here in Canada can spend some time on Thursday and > > Friday merging some of them in :) ) On Mon Nov 24 2014 at 5:28:51 PM > > Steven Gill <stevengil...@gmail.com> wrote: > > > > > I want to do a plugins release next Monday, Dec 1. (Thursday/Friday > > > are holidays in the states). > > > > > > I will review PRs the next few days, please bring any that you deem > > > important to my attention. > > > > > >
