Github user clelland commented on the pull request:

    
https://github.com/apache/cordova-plugin-inappbrowser/pull/62#issuecomment-64897545
  
    Thanks for this! I'm sorry that we can't pull this in as-is, because of all 
of the other commits on top of it. I might be able to cherrypick the one 
commit, but it would be easier if you could create a branch for it, and a new 
PR.
    
    Also, a couple of other small things: Is there a JIRA issue for this? It 
helps us keep track of why each line of code was added to the project. Also, we 
usually request an ICLA from contributors for anything bigger than a couple of 
lines -- it's really simple, you can see the form at 
http://www.apache.org/licenses/#clas


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to