Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/22#discussion_r21073185 --- Diff: tests/tests.js --- @@ -20,6 +20,9 @@ */ exports.defineAutoTests = function () { + var isWindows = (cordova.platformId === "windows") || (cordova.platformId === "windows8"), + isAccelExist = isWindows ? Windows.Devices.Sensors.Accelerometer.getDefault() !== null : false; --- End diff -- 1. To generic variable name, rename isAccelExist -> isAccelExistWidows since this check applies to Windows only 2. I think this breaks check on non-Widnows devices since isAccelExist is always FALSE on non-Windows platforms You should do if (isWindows && !isAccelExistWindows) { pending }
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org