Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/40#issuecomment-68805346
I would argue that if "To add it it Android and WP it seems not quite
easy." then it should NOT be added at all.
The way this is implemented currently, any call to setRate on platforms
other that iOS will still reach native code and potentially crash. At a
minimum, I would wrap the exec call in Media.js : Media.prototype.setRate so
that it is not called on other platforms, and simply outputs NOTSUPPORTED or
something.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
