I vote +1: • Verified signatures and hashes • Installed Cordova from archives • Verified ability to create and run Cordova app with android, windows, android and WP8 platforms
Thx! Sergey -----Original Message----- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Thursday, January 8, 2015 9:33 PM To: dev Subject: Re: [Vote] Tools Release Jan 6, 2015 That's awesome that you found this bug! But I agree with Steve. If it's not a regression, then there's no point in delaying a release. On Thu, Jan 8, 2015 at 1:25 PM, Steven Gill <stevengil...@gmail.com> wrote: > That is not something that should stop the tools release. IOS isn't > even being updated in this release. The current released tools must > have the same issue. > > This release is about getting users the updated blackberry, ubuntu and > windows platform releases. iOS can fix the bug, do a platform release > and then do a new tools release (cordova 4.2.1). > > I don't believe we should stop this release and wait for iOS. This is > one of the main reasons we switched to independent platform releases! > > On Thu, Jan 8, 2015 at 9:04 AM, Josh Soref <jso...@blackberry.com> wrote: > > > Fwiw, I just filed a bug against cordova-ios, `cordova platform > > update ios` isn't working. > > > > I'm -1 on shipping with this stuff broken. > > > > It's technically a bug in cordova-ios and not the tools, but it > > pretty much sucks, and it means our tools coverage/testing isn't > > sufficiently comprehensive. > > > > Note that cordova-android and cordova-blackberry10 don't suffer from > > this (because they include node_modules) > > > > On 1/7/15, 7:24 PM, "Mark Koudritsky" <kam...@google.com> wrote: > > > > >+1 > > > > > >Tests: > > > - npm install -g cordova@rc > > > - Built and ran the default HelloWorld app on Android > > > - ran "coho verify-tags" > > > > > > > > >On Wed, Jan 7, 2015 at 4:27 PM, Andrew Grieve > > ><agri...@chromium.org> > > >wrote: > > > > > >> +1 > > >> > > >> * Confirmed sigs & hashes with `coho verify-archive` > > >> * Verified sha1s match tags with `coho verify-tags` > > >> * Re-created archives to ensure contents match release candidate > > >> (did > so > > >> for cordova-js and cordova-cli) > > >> > > >> On Tue, Jan 6, 2015 at 8:46 PM, Steven Gill > > >> <stevengil...@gmail.com> > > >> wrote: > > >> > > >> > Please review and vote on this Tools Release. > > >> > > > >> > Release issue: https://issues.apache.org/jira/browse/CB-8256 > > >> > > > >> > All tools have been published to > > >> > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8256 > > >> > / > > >> > > > >> > The packages were published from their corresponding git tags: > > >> > cordova-js: 3.7.3 (8d6b736a36) > > >> > cordova-lib: 4.2.0 (52f7db9dfc) > > >> > cordova-plugman: 0.22.17 (016ef62e7e) > > >> > cordova-cli: 4.2.0 (afa8016230) > > >> > > > >> > You can test the rc by going npm install -g cordova@rc. > > >> > > > >> > I'd especially love if the windows and blackberry guys can test it! > > >> > > > >> > > > >> > Upon a successful vote I will upload the archives to dist/, > > >> > publish them to NPM, and post the corresponding blog post. > > >> > > > >> > Voting guidelines: > > >> > > > >> > > >> > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting > .md > > >> > > > >> > Voting will go on for a minimum of 48 hours. > > >> > > > >> > I vote +1: > > >> > * Ran coho audit-license-headers over the relevant repos > > >> > * Ran coho check-license to ensure all dependencies and > > >> > subdependencies have Apache-compatible licenses > > >> > * ran unit tests + mobile spec on android + ios > > >> > > > >> > > >
