Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/149#discussion_r23201158
--- Diff: framework/src/org/apache/cordova/CordovaWebViewClient.java ---
@@ -171,8 +171,13 @@ public void onPageStarted(WebView view, String url,
Bitmap favicon) {
public void onPageFinished(WebView view, String url) {
super.onPageFinished(view, url);
// Ignore excessive calls.
- if (!isCurrentlyLoading) {
- return;
+ // On KitKat, loading about:blank does not invoke
WebViewClient#onPageStarted
+ // So do not check isCurrentLoading if app is running on KitKat
+ // https://code.google.com/p/android/issues/detail?id=65701
+ if (android.os.Build.VERSION.SDK_INT !=
android.os.Build.VERSION_CODES.KITKAT){
--- End diff --
Hmm, saw your comment about maybe setting it in loadUrlNow(). Wondering if
maybe the best thing to do is just ignore the check when
url.startsWith("about:")? WDYT? e.g.:
if (!isCurrentlyLoading && !url.startsWith("about:")) {
return;
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
