ah, I missed that lstatSync throws an exception for non-string args. I suppose that's fine. Will merge!
On Wed, Feb 11, 2015 at 2:54 PM, omefire <g...@git.apache.org> wrote: > Github user omefire commented on a diff in the pull request: > > https://github.com/apache/cordova-lib/pull/162#discussion_r24527527 > > --- Diff: cordova-lib/src/cordova/plugin.js --- > @@ -114,6 +116,22 @@ module.exports = function plugin(command, > targets, opts) { > target = target.substring(0, > target.length - 1); > } > > + var parts = target.split('@'); > + var id = parts[0]; > + var version = parts[1]; > + > + // If no version is specified, retrieve the > version from config.xml > + if(!version && !cordova_util.isUrl(id) && > !cordova_util.isDirectory(id)){ > + events.emit('verbose', 'no version > specified, retrieving version from config.xml'); > + var ver = getVersionFromConfigFile(id, > cfg); > + > + if( cordova_util.isUrl(ver) || > cordova_util.isDirectory(ver) ){ > --- End diff -- > > @agrieve, isDirectory does handle the null/undefined cases. I just > tested it. Am I missing something ? > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > --- > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
