Github user omefire commented on the pull request:

    https://github.com/apache/cordova-lib/pull/174#issuecomment-76532764
  
    It currently doesn't work in 100% of the cases but I do agree we can 
postpone the fix. 
    
    I don't really care what the name of the element is : '<variable>' or 
something else. As long as it works, I'm fine with it. 
    
    Although it is NOT written anywhere that '<variable>' is the name to be 
used, the code is currently saying a different story(long before this change). 
In fact, "ConfigParser.getFeature(id)" does assume that variables are under the 
'<variable>' element name. That's why changing things to '<variable>' fixes 
this issue.
    
    Like I said, I'm fine if instead you want to modify the name to something 
else.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to