Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/175#discussion_r25671898 --- Diff: cordova-lib/src/plugman/registry/registry.js --- @@ -218,10 +205,18 @@ module.exports = { /** * @method initSettings + * @param {Boolean} using npm registry * @return {Promise.<Object>} Promised settings. */ -function initSettings() { +function initSettings(npm) { var settings = module.exports.settings; + var registryURL = 'http://registry.cordova.io'; + + //if npm is true, use npm registry + if(npm) { + registryURL = 'http://registry.npmjs.org'; + } + --- End diff -- Minor nit - rather than setting registryURL to one value, then potentially setting it to another value, why not just: var registryURL = npm ? 'http://registry.npmjs.org' : 'http://registry.cordova.io';
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org