Github user mmocny commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/175#discussion_r25709236
  
    --- Diff: cordova-lib/src/cordova/plugin.js ---
    @@ -238,7 +239,21 @@ module.exports = function plugin(command, targets, 
opts) {
                     return opts.plugins.reduce(function(soFar, target) {
                         // Check if we have the plugin.
                         if (plugins.indexOf(target) < 0) {
    -                        return Q.reject(new CordovaError('Plugin "' + 
target + '" is not present in the project. See `'+cordova_util.binname+' plugin 
list`.'));
    +                        // Convert target from package-name to package-id 
if necessary
    +                        var keys = Object.keys(pluginMapper);
    +                        //Traverse through pluginMapper values to see if 
it equals our target.
    +                        //Cordova-plugin-device would get changes to 
org.apache.cordova.device
    +                        for (var i = 0; i < keys.length; i++) {
    --- End diff --
    
    Nevermind, I see its doing reverse mapping.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to