Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-medic/pull/37#discussion_r26008134
  
    --- Diff: bin/checkout.js ---
    @@ -0,0 +1,53 @@
    +#!/usr/bin/env node
    +
    +// node dependencies
    +var fs = require('fs');
    +
    +// external dependencies
    +var shell = require('shelljs');
    +
    +// parse args
    +var argv = require('optimist')
    +    .usage('Usage: $0 --config [path] --project [name]')
    +    .demand('config')
    +    .argv;
    +
    +function cloneProject(projectName, projectsConfig) {
    +
    +    var project  = projectsConfig[projectName];
    +    var codebase = project.codebases[project.codebase];
    +    var command  = 'git clone ' + codebase.repo + ' --branch=' + 
codebase.branch + ' --depth 1'
    +
    +    shell.exec(command, {async: true, silent: false, fatal: false});
    --- End diff --
    
    Also, we are queuing an async operation without waiting for it - I'm not 
sure if that's a good idea. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to