Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26233744
--- Diff: cordova-lib/src/PluginInfo.js ---
@@ -288,6 +293,19 @@ function PluginInfo(dirname) {
return ret;
});
};
+
+ self.getFilesAndFrameworks = getFilesAndFrameworks;
+ function getFilesAndFrameworks(platform) {
+ var items = [];
+ // Please avoid changing the order of the calls below, files will
be
+ // installed in this order.
+ items = items.concat(self.getSourceFiles(platform));
+ items = items.concat(self.getHeaderFiles(platform));
+ items = items.concat(self.getResourceFiles(platform));
+ items = items.concat(self.getFrameworks(platform));
+ items = items.concat(self.getLibFiles(platform));
--- End diff --
I would recommend :
var items = [];
items = items.concat(self.getSourceFiles(platform),
self.getHeaderFiles(platform),
... );
// unnecessarily tricky code is a barrier to some, clarity is king
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
